[Eg-newdevs] Follow-up to today's meeting

Fri Aug 19 09:27:00 EDT 2022

Thanks Terran! Great progress!

I was looking at ways to reliably reproduce the saving problem on
current master, once the requireCN check is working.

I think I identified two cases where saving fails. Both cases depend on the
call number label NOT being automatically filled in with a bib call number:

1. Add Holdings to a record with a blank label, choosing call number
attributes that would match an existing call number in the database
2. Do not click in or edit the call number label field
3. Save

The holdings editor closes and the Save fails silently. log error:

open-ils.cstore 2022-08-18 14:13:59 [ERR
:7282:oils_sql.c:2531:1660846412744836] open-ils.cstore ERROR inserting
asset::call_number object using query [INSERT INTO asset.call_number
(create_date,creator,deleted,edit_date,editor,id,label,owning_lib,record,label_sortkey,label_class,prefix,suffix)
VALUES ('now',1,DEFAULT,'now',1,DEFAULT,'',4,216,DEFAULT,1,5,-1);]: 3505685
3505685: ERROR:  duplicate key value violates unique constraint
"asset_call_number_label_once_per_lib"

1. Add Holdings to a record with a blank label, choosing call number
attributes that do not match an existing call number in the database.
2. Do not click in or edit the call number label field
3. Save

The holdings editor closes and the Save fails silently. log errors:

open-ils.cstore 2022-08-18 14:27:46 [ERR
:7542:oils_sql.c:2531:1660847246756636] open-ils.cstore ERROR inserting
asset::call_number object using query [INSERT INTO asset.call_number
(create_date,creator,deleted,edit_date,editor,id,label,owning_lib,record,label_sortkey,label_class,prefix,suffix)
VALUES ('now',1,DEFAULT,'now',1,DEFAULT,DEFAULT,4,258,DEFAULT,1,5,-1);]:
3452548 3452548: ERROR:  query string argument of EXECUTE is null

2022-08-18 20:51:24.348 UTC [32220] evergreen at evergreen CONTEXT:  PL/pgSQL
function asset.label_normalizer() line 16 at EXECUTE
2022-08-18 20:51:24.348 UTC [32220] evergreen at evergreen STATEMENT:  INSERT
INTO asset.call_number
(create_date,creator,deleted,edit_date,editor,id,label,owning_lib,record,label_sortkey,label_class,prefix,suffix)
VALUES
('now',53,DEFAULT,'now',53,DEFAULT,DEFAULT,37,2876840,DEFAULT,1,3617,-1);

--
Michele M. Morgan, Technical Support Analyst
North of Boston Library Exchange, Danvers Massachusetts
mmorgan at noblenet.org

On Thu, Aug 18, 2022 at 4:36 PM Terran McCanna via Eg-newdevs <
eg-newdevs at list.evergreen-ils.org> wrote:

> Hi everyone,
>
> I worked on this some more today, and I *think* it might be close to
> working? It will need testing from people that actually know how to do
> cataloging.
>
> I moved the requireCN check from volcopy.component.ts where we were
> looking yesterday into vol-edit.component.ts instead (and called it
> requireCNL now to be a little more clear). In that file there is a section
> that sets a "badVols" constant so I added an if/else statement in there.
> You can see the latest changes I made in the top commit here:
>
>
> https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1821950-call-number-labels-not-required
>
> So, when we meet in the morning, let's poke some more at this to see if
> there is more that needs to be done. For one thing, I have no idea how to
> make the red warning bar in the call number label go away when it isn't
> required.
>
> If we can get this all resolved, then maybe we'll have time to look at the
> AngularJS saving problem too.
>
> See you in the morning! 10 am Eastern, login info here:
> https://wiki.evergreen-ils.org/doku.php?id=newdevs:meetings:agenda-2022-08
>
>
>
>
>
>
> Terran McCanna, PINES Program Manager
> ------------------------------
>
> Georgia Public Library Service | University System of Georgia
>
> 2872 Woodcock Blvd, Suite 250 l Atlanta, GA 30341
>
> (404) 235-7138 | tmccanna at georgialibraries.org
>
> http://help.georgialibraries.org | help at georgialibraries.org
>
> <https://www.facebook.com/georgialibraries>
> <https://www.twitter.com/georgialibs>
> <https://www.instagram.com/georgialibraries/>
> <https://www.twitter.com/georgialibs>
>
> Join our email list <http://georgialibraries.org> for stories of Georgia
> libraries making an impact in our communities.
>
>
>
> On Tue, Aug 16, 2022 at 4:28 PM Terran McCanna <
> tmccanna at georgialibraries.org> wrote:
>
>> Hi everyone,
>>
>> So far today we figured out how to grab the value of the new org unit
>> setting that Kyle built in the Angular interface. Work in progress here:
>>
>>
>> https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1821950-call-number-labels-not-required
>>
>> Next, we will need to figure out how to use that value to determine
>> whether or not to enable the Save button.
>>
>> Then, we will need to figure out how to resolve the null - string
>> conflict that is occurring upon save.
>>
>> So we don't lose momentum, we have set up another meeting this week on
>> Friday morning at 10am Eastern for anyone who is able to participate:
>>
>> New Devs Working Group: Special Edition
>> Friday, August 19 · 10:00 – 11:00am
>> Google Meet joining info
>> Video call link: https://meet.google.com/xgu-itxv-izx
>> Or dial: ‪(US) +1 218-481-1325‬ PIN: ‪954 609 909‬#
>> More phone numbers: https://tel.meet/xgu-itxv-izx?pin=4790384037313
>>
>>
>>
>>
>> Terran McCanna, PINES Program Manager
>> ------------------------------
>>
>> Georgia Public Library Service | University System of Georgia
>>
>> 2872 Woodcock Blvd, Suite 250 l Atlanta, GA 30341
>>
>> (404) 235-7138 | tmccanna at georgialibraries.org
>>
>> http://help.georgialibraries.org | help at georgialibraries.org
>>
>> <https://www.facebook.com/georgialibraries>
>> <https://www.twitter.com/georgialibs>
>> <https://www.instagram.com/georgialibraries/>
>> <https://www.twitter.com/georgialibs>
>>
>> Join our email list <http://georgialibraries.org> for stories of Georgia
>> libraries making an impact in our communities.
>>
>> _______________________________________________
> Eg-newdevs mailing list
> Eg-newdevs at list.evergreen-ils.org
> http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/eg-newdevs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.evergreen-ils.org/pipermail/eg-newdevs/attachments/20220819/f3041d52/attachment-0001.htm>