<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Aptos;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-CA" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">That is great news!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Thank you Mary, Ian, and the New Devs group for finding and fixing this bug!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Jennifer<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">--<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Jennifer Pringle (she/her)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Co-op Support - Training Lead<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">BC Libraries Cooperative<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Toll-free: 1-888-848-9250<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Email:jennifer.pringle@bc.libraries.coop<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Website: <a href="http://bc.libraries.coop">
<span style="color:#467886">http://bc.libraries.coop</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Gratefully acknowledging that I live and work in the unceded Traditional Territory of the St'at'yemc Nations.<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Evergreen-acq <evergreen-acq-bounces@list.evergreen-ils.org>
<b>On Behalf Of </b>Tiffany Little via Evergreen-acq<br>
<b>Sent:</b> October 21, 2024 6:02 AM<br>
<b>To:</b> Evergreen ACQ Listserv <evergreen-acq@list.evergreen-ils.org><br>
<b>Cc:</b> Tiffany Little <tlittle@georgialibraries.org><br>
<b>Subject:</b> [Evergreen-acq] Fwd: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span style="font-family:"Tahoma",sans-serif">Good morning,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Tahoma",sans-serif"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Tahoma",sans-serif">Good news! The bug that Mary brought up at our last meeting--where line items couldn't be true canceled--now has a fix! Thank you to Ian from Bibliomation for the fix, and to the New Devs group
for reviewing and creating unit tests for the problem.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Tahoma",sans-serif"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Tahoma",sans-serif">This is now Fix Committed for 3_13 and above (thanks Jane!).<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Tahoma",sans-serif"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:"Tahoma",sans-serif">Tiffany<o:p></o:p></span></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" style="border-collapse:collapse">
<tbody>
<tr style="height:74.25pt">
<td valign="top" style="padding:.75pt .75pt .75pt .75pt;height:74.25pt;overflow:hidden">
<p align="right" style="margin:0cm;text-align:right"><a href="https://georgialibraries.org/" target="_blank"><span style="font-size:11.0pt;font-family:"Arial",sans-serif;color:#1155CC;border:none windowtext 1.0pt;padding:0cm;text-decoration:none"><img border="0" width="75" height="75" style="width:.7797in;height:.7797in" id="Picture_x0020_1" src="cid:~WRD0000.jpg" alt="Image removed by sender. logo with link to Georgia Public Library Service website"></span></a><span style="color:black"><o:p></o:p></span></p>
</td>
<td valign="top" style="padding:5.0pt 5.0pt 5.0pt 5.0pt;height:74.25pt;overflow:hidden">
<p style="margin:0cm"><b><span style="font-size:13.0pt;font-family:"Verdana",sans-serif;color:#1E439B">Tiffany Little</span></b><span style="color:black"><o:p></o:p></span></p>
<p style="margin:0cm"><b><span style="font-size:13.0pt;font-family:"Verdana",sans-serif;color:#1E439B">PINES Bibliographic Projects Manager</span></b><span style="color:black"><o:p></o:p></span></p>
<div class="MsoNormal" align="center" style="text-align:center"><span style="color:black">
<hr size="2" width="100%" align="center">
</span></div>
<p style="margin:0cm"><b><span style="font-family:"Verdana",sans-serif;color:#1E439B">Georgia Public Library Service</span></b><span style="color:black"><o:p></o:p></span></p>
<p style="margin:0cm"><span style="font-family:"Verdana",sans-serif;color:#1E439B">2872 Woodcock Blvd, Suite 250 | Atlanta, GA 30341</span><span style="color:black"><o:p></o:p></span></p>
<p style="margin:0cm"><span style="font-family:"Verdana",sans-serif;color:#1E439B">(404) 235-7161 |
<a href="mailto:tlittle@georgialibraries.org" target="_blank"><span style="color:#1155CC">tlittle@georgialibraries.org</span></a></span><span style="color:black"><o:p></o:p></span></p>
</td>
</tr>
<tr style="height:36.0pt">
<td valign="top" style="padding:.75pt .75pt .75pt .75pt;height:36.0pt;overflow:hidden">
</td>
<td valign="top" style="padding:5.0pt 5.0pt 5.0pt 5.0pt;height:36.0pt;overflow:hidden">
<p style="margin:0cm"><a href="https://www.facebook.com/georgialibraries" target="_blank"><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:#1155CC;border:none windowtext 1.0pt;padding:0cm;text-decoration:none"><img border="0" width="36" height="36" style="width:.375in;height:.375in" id="Picture_x0020_3" src="cid:~WRD0000.jpg" alt="Image removed by sender. logo with link to Georgia Public Library Service Facebook page"></span></a><a href="https://www.instagram.com/georgialibraries/" target="_blank"><b><span style="font-size:11.0pt;font-family:"Verdana",sans-serif;color:#1155CC;border:none windowtext 1.0pt;padding:0cm;text-decoration:none"><img border="0" width="34" height="34" style="width:.3571in;height:.3571in" id="Picture_x0020_4" src="cid:~WRD0000.jpg" alt="Image removed by sender. logo with link to Georgia Public Library Service Instagram page"></span></b></a><a href="https://www.linkedin.com/company/georgia-public-library-service/" target="_blank"><span style="font-size:9.0pt;font-family:"Verdana",sans-serif;color:#1155CC;border:none windowtext 1.0pt;padding:0cm;text-decoration:none"><img border="0" width="36" height="36" style="width:.375in;height:.375in" id="Picture_x0020_5" src="cid:~WRD0000.jpg" alt="Image removed by sender. logo with link to Georgia Public Library Service LinkedIn page"></span></a><a href="https://www.threads.net/@georgialibraries" target="_blank"><b><span style="font-size:11.0pt;font-family:"Verdana",sans-serif;color:#1155CC;border:none windowtext 1.0pt;padding:0cm;text-decoration:none"><img border="0" width="34" height="34" style="width:.3571in;height:.3571in" id="Picture_x0020_6" src="cid:~WRD0000.jpg" alt="Image removed by sender. logo with link to Georgia Public Library Service Threads page"></span></b></a><span style="color:black"><o:p></o:p></span></p>
</td>
</tr>
<tr>
<td valign="top" style="padding:.75pt .75pt .75pt .75pt;overflow:hidden"></td>
<td valign="top" style="padding:5.0pt 5.0pt 5.0pt 5.0pt;overflow:hidden">
<p style="margin:0cm"><span style="color:black"><a href="http://georgialibraries.org/subscription" target="_blank"><i><span style="font-size:11.0pt;font-family:"Verdana",sans-serif;color:#1155CC">Join our email list</span></i></a></span><i><span style="font-size:11.0pt;font-family:"Verdana",sans-serif;color:black">
</span></i><i><span style="font-size:11.0pt;font-family:"Verdana",sans-serif;color:#434343">for stories of Georgia libraries making an impact in our communities.</span></i><span style="color:black"><o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">---------- Forwarded message ---------<br>
From: <strong><span style="font-family:"Aptos",sans-serif">Jane Sandberg</span></strong> <<a href="mailto:2084096@bugs.launchpad.net">2084096@bugs.launchpad.net</a>><br>
Date: Thu, Oct 17, 2024 at 12:05<span style="font-family:"Arial",sans-serif"> </span>PM<br>
Subject: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason<br>
To: <<a href="mailto:tlittle@georgialibraries.org">tlittle@georgialibraries.org</a>><o:p></o:p></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
<br>
Fix confirmed in yesterday's newdevs meeting. I've pushed this to<br>
rel_3_13 and above. Thanks, Ian, and all collaborators at yesterday's<br>
meeting!<br>
<br>
** Changed in: evergreen<br>
Assignee: Ian Skelskey (ianskelskey) => (unassigned)<br>
<br>
** Changed in: evergreen<br>
Status: Confirmed => Fix Committed<br>
<br>
** Also affects: evergreen/3.13<br>
Importance: Undecided<br>
Status: New<br>
<br>
** Changed in: evergreen<br>
Milestone: None => 3.14.1<br>
<br>
** Changed in: evergreen<br>
Milestone: 3.14.1 => 3.14.0<br>
<br>
** Changed in: evergreen/3.13<br>
Milestone: None => 3.13.5<br>
<br>
** Changed in: evergreen/3.13<br>
Importance: Undecided => High<br>
<br>
** Changed in: evergreen/3.13<br>
Status: New => Fix Committed<br>
<br>
** Tags added: pullrequest signedoff<br>
<br>
-- <br>
You received this bug notification because you are subscribed to the bug<br>
report.<br>
<a href="https://bugs.launchpad.net/bugs/2084096" target="_blank">https://bugs.launchpad.net/bugs/2084096</a><br>
<br>
Title:<br>
Line items cannot be canceled using a true cancel reason<br>
<br>
Status in Evergreen:<br>
Fix Committed<br>
Status in Evergreen 3.13 series:<br>
Fix Committed<br>
<br>
Bug description:<br>
Tested on a 3.14-beta and also seen on a 3.13 test server.<br>
<br>
Trying to cancel a line item with associated catalog items (eg copy<br>
ids) fails silently. There are two console error produced:<br>
<br>
open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:<br>
Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.<br>
<br>
<br>
ERROR Error: Uncaught (in promise): open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:<br>
Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.<br>
<br>
<br>
at resolvePromise (zone.js:1214:31)<br>
at resolvePromise (zone.js:1168:17)<br>
at zone.js:1281:17<br>
at _ZoneDelegate.invokeTask (zone.js:409:31)<br>
at core.mjs:23896:55<br>
at AsyncStackTaggingZoneSpec.onInvokeTask (core.mjs:23896:36)<br>
at _ZoneDelegate.invokeTask (zone.js:408:60)<br>
at Object.onInvokeTask (core.mjs:24197:33)<br>
at _ZoneDelegate.invokeTask (zone.js:408:60)<br>
at Zone.runTask (zone.js:178:47)<br>
<br>
<br>
To reproduce:<br>
1. Create a purchase order.<br>
2. Add a line item with item, estimated price, owning lib, shelving location and fund.<br>
3. Activate purchase order. Do *not* choose "Activate without loading items.<br>
4. Cancel the line item using a cancel reason that does not keep fund debits. (Cancel reason should start with "Canceled".)<br>
5. You will see the console error appear, but the page doesn't refresh and no error is given.<br>
<br>
This breaks a fundamental piece of Acquisitions, and is considered a<br>
acq blocker for 3.13 and 3.14 by the AIG.<br>
<br>
To manage notifications about this bug go to:<br>
<a href="https://bugs.launchpad.net/evergreen/+bug/2084096/+subscriptions" target="_blank">https://bugs.launchpad.net/evergreen/+bug/2084096/+subscriptions</a><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal">This message originated from outside the M365 organisation. Please be careful with links, and don't trust messages you don't recognise.
<o:p></o:p></p>
</div>
</body>
</html>