<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">Good morning,</div><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">Good news! The bug that Mary brought up at our last meeting--where line items couldn't be true canceled--now has a fix! Thank you to Ian from Bibliomation for the fix, and to the New Devs group for reviewing and creating unit tests for the problem.</div><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">This is now Fix Committed for 3_13 and above (thanks Jane!).</div><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">Tiffany</div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><br><br><table style="color:rgb(0,0,0);border:none;border-collapse:collapse"><colgroup><col width="76"><col width="7"><col width="64"><col width="437"></colgroup><tbody><tr style="height:74.25pt"><td colspan="2" style="vertical-align:top;overflow:hidden"><p dir="ltr" style="line-height:1.2;text-align:right;margin-top:0pt;margin-bottom:0pt"><a href="https://georgialibraries.org/" style="color:rgb(17,85,204)" target="_blank"><span style="font-size:11pt;font-family:Arial,sans-serif;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:75px;height:75px"><img alt="logo with link to Georgia Public Library Service website" src="https://lh7-us.googleusercontent.com/Vg2xXDqxOrtUgPk2M0oSlTBdteuYiC76bzt132CXg6s31gyccGHWcAogBUtm5M-v7xvOf4AfE5-Fpzw-Lac0NDN9zyFhyfYH6D8HmB-dvFSFB0-HkICThiJheqtQK4fUmNUucxBCsFpeqArRkBACcRI" width="75" height="75" style="margin-left:0px;margin-top:0px"></span></span></a></p></td><td colspan="2" style="vertical-align:top;padding:5pt;overflow:hidden"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:13pt;font-family:Verdana,sans-serif;color:rgb(30,67,155);font-weight:700;vertical-align:baseline">Tiffany Little</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><font color="#1e439b" face="Verdana, sans-serif"><span style="font-size:17.3333px"><b>PINES Bibliographic Projects Manager</b></span></font></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"></p><hr><p></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:12pt;font-family:Verdana,sans-serif;font-weight:700;vertical-align:baseline"></span><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(30,67,155);font-weight:700;vertical-align:baseline">Georgia Public Library Service</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(30,67,155);vertical-align:baseline">2872 Woodcock Blvd, Suite 250 | Atlanta, GA 30341</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:12pt;font-family:Verdana,sans-serif;color:rgb(30,67,155);vertical-align:baseline">(404) 235-7161 | <a href="mailto:tlittle@georgialibraries.org" style="color:rgb(17,85,204)" target="_blank">tlittle@georgialibraries.org</a></span></p></td></tr><tr style="height:36pt"><td colspan="2" style="vertical-align:top;overflow:hidden"><br></td><td colspan="2" style="vertical-align:top;padding:5pt;overflow:hidden"><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:0pt"><a href="https://www.facebook.com/georgialibraries" style="color:rgb(17,85,204)" target="_blank"><span style="font-size:9pt;font-family:Verdana,sans-serif;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:36px;height:36px"><img alt="logo with link to Georgia Public Library Service Facebook page" src="https://lh7-us.googleusercontent.com/-er3O1_1HYT7v2KrF3eEa_hYUbW2WsJ9NyIcYgdoQqCQFghj2oi7VtwZ5ge031mxvJk80d_Q79BXXdZCikPc3hLQdV6Yp0eml1hk0chn5tyv7kN64jff0-QHdrMdMLzPKZ_qtcyS7GD5ofQR8wHq4hc" width="36" height="36" style="margin-left:0px;margin-top:0px"></span></span></a><a href="https://www.instagram.com/georgialibraries/" style="color:rgb(17,85,204)" target="_blank"><span style="font-size:11pt;font-family:Verdana,sans-serif;font-weight:700;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:34px;height:34px"><img alt="logo with link to Georgia Public Library Service Instagram page" src="https://lh7-us.googleusercontent.com/Ln7S31I1dTqs0P1h3_8SZOPJN6uzYQTYO6EmIhIgK_WSB1g-4-LSL-V5cjUqq9MnE4YtcQG4HmIsooAJacuG9n-aZ7396CILuynx--RY4dQnCO4vO3GJahVc5UD7-Y5tiWsOWVLwvGFHT692KojhO0o" width="34" height="34" style="margin-left:0px;margin-top:0px"></span></span></a><a href="https://www.linkedin.com/company/georgia-public-library-service/" style="color:rgb(17,85,204)" target="_blank"><span style="font-size:9pt;font-family:Verdana,sans-serif;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:36px;height:36px"><img alt="logo with link to Georgia Public Library Service LinkedIn page" src="https://lh7-us.googleusercontent.com/WM-Vyk1ysfUPyPFkxWbTLoMxE9lGlrVeGim2O48I-SjXXzcVm4aiYI54sea75bUyOPQk6QMvnYNsMoyOWu6yeu_-qeRSe-ljXzjAWsQR8-HMm9v74ElbzxhV8GsCLd8owbNaALv6wKx-F37VJZGzNk8" width="36" height="36" style="margin-left:0px;margin-top:0px"></span></span></a><a href="https://www.threads.net/@georgialibraries" style="color:rgb(17,85,204)" target="_blank"><span style="font-size:11pt;font-family:Verdana,sans-serif;font-weight:700;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:34px;height:34px"><img alt="logo with link to Georgia Public Library Service Threads page" src="https://lh7-us.googleusercontent.com/5w2EFp12fdhrhHmPs9ajMem8wYMLqUtaWgu1vwfT6t8A7QM-Y4wm9YN3YRH-M3njPmzXo8HyQfSJWKm3TfWAXqyj8vBTT_W9nDyVa-ch3Tz4F_sIvZr27e-817f_Vpxb07sBiu7S593ZPmrigcE19IY" width="34" height="34" style="margin-left:0px;margin-top:0px"></span></span></a></p></td></tr><tr style="height:0pt"><td colspan="2" style="vertical-align:top;overflow:hidden"><br></td><td colspan="2" style="vertical-align:top;padding:5pt;overflow:hidden"><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:0pt"><a href="http://georgialibraries.org/subscription" style="color:rgb(17,85,204)" target="_blank"><span style="font-size:11pt;font-family:Verdana,sans-serif;font-style:italic;vertical-align:baseline">Join our email list</span></a><span style="font-size:11pt;font-family:Verdana,sans-serif;font-style:italic;vertical-align:baseline"> </span><span style="font-size:11pt;font-family:Verdana,sans-serif;color:rgb(67,67,67);font-style:italic;vertical-align:baseline">for stories of Georgia libraries making an impact in our communities.</span></p></td></tr></tbody></table></div></div></div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>From: <strong class="gmail_sendername" dir="auto">Jane Sandberg</strong> <span dir="auto"><<a href="mailto:2084096@bugs.launchpad.net">2084096@bugs.launchpad.net</a>></span><br>Date: Thu, Oct 17, 2024 at 12:05 PM<br>Subject: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason<br>To: <<a href="mailto:tlittle@georgialibraries.org">tlittle@georgialibraries.org</a>><br></div><br><br>Fix confirmed in yesterday's newdevs meeting. I've pushed this to<br>
rel_3_13 and above. Thanks, Ian, and all collaborators at yesterday's<br>
meeting!<br>
<br>
** Changed in: evergreen<br>
Assignee: Ian Skelskey (ianskelskey) => (unassigned)<br>
<br>
** Changed in: evergreen<br>
Status: Confirmed => Fix Committed<br>
<br>
** Also affects: evergreen/3.13<br>
Importance: Undecided<br>
Status: New<br>
<br>
** Changed in: evergreen<br>
Milestone: None => 3.14.1<br>
<br>
** Changed in: evergreen<br>
Milestone: 3.14.1 => 3.14.0<br>
<br>
** Changed in: evergreen/3.13<br>
Milestone: None => 3.13.5<br>
<br>
** Changed in: evergreen/3.13<br>
Importance: Undecided => High<br>
<br>
** Changed in: evergreen/3.13<br>
Status: New => Fix Committed<br>
<br>
** Tags added: pullrequest signedoff<br>
<br>
-- <br>
You received this bug notification because you are subscribed to the bug<br>
report.<br>
<a href="https://bugs.launchpad.net/bugs/2084096" rel="noreferrer" target="_blank">https://bugs.launchpad.net/bugs/2084096</a><br>
<br>
Title:<br>
Line items cannot be canceled using a true cancel reason<br>
<br>
Status in Evergreen:<br>
Fix Committed<br>
Status in Evergreen 3.13 series:<br>
Fix Committed<br>
<br>
Bug description:<br>
Tested on a 3.14-beta and also seen on a 3.13 test server.<br>
<br>
Trying to cancel a line item with associated catalog items (eg copy<br>
ids) fails silently. There are two console error produced:<br>
<br>
open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:<br>
Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.<br>
<br>
<br>
ERROR Error: Uncaught (in promise): open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:<br>
Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.<br>
<br>
<br>
at resolvePromise (zone.js:1214:31)<br>
at resolvePromise (zone.js:1168:17)<br>
at zone.js:1281:17<br>
at _ZoneDelegate.invokeTask (zone.js:409:31)<br>
at core.mjs:23896:55<br>
at AsyncStackTaggingZoneSpec.onInvokeTask (core.mjs:23896:36)<br>
at _ZoneDelegate.invokeTask (zone.js:408:60)<br>
at Object.onInvokeTask (core.mjs:24197:33)<br>
at _ZoneDelegate.invokeTask (zone.js:408:60)<br>
at Zone.runTask (zone.js:178:47)<br>
<br>
<br>
To reproduce:<br>
1. Create a purchase order.<br>
2. Add a line item with item, estimated price, owning lib, shelving location and fund.<br>
3. Activate purchase order. Do *not* choose "Activate without loading items.<br>
4. Cancel the line item using a cancel reason that does not keep fund debits. (Cancel reason should start with "Canceled".)<br>
5. You will see the console error appear, but the page doesn't refresh and no error is given.<br>
<br>
This breaks a fundamental piece of Acquisitions, and is considered a<br>
acq blocker for 3.13 and 3.14 by the AIG.<br>
<br>
To manage notifications about this bug go to:<br>
<a href="https://bugs.launchpad.net/evergreen/+bug/2084096/+subscriptions" rel="noreferrer" target="_blank">https://bugs.launchpad.net/evergreen/+bug/2084096/+subscriptions</a><br>
<br>
</div></div>