<div dir="ltr">Hi all,<div><br></div><div>Does this also fix <a href="https://bugs.launchpad.net/evergreen/+bug/2081760">Bug #2081760: Batch Update cancel lineitem cancel reason silently fails</a>?</div><div><br></div><div>Thanks,</div><div><br>Carol</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 21, 2024 at 12:24 PM Jennifer Pringle via Evergreen-acq <<a href="mailto:evergreen-acq@list.evergreen-ils.org">evergreen-acq@list.evergreen-ils.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-5390723156629617995">
<div lang="EN-CA" style="overflow-wrap: break-word;">
<div class="m_-5390723156629617995WordSection1">
<p class="MsoNormal"><span style="font-size:11pt">That is great news!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Thank you Mary, Ian, and the New Devs group for finding and fixing this bug!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Jennifer<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span style="font-size:11pt">--<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Jennifer Pringle (she/her)<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Co-op Support - Training Lead<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">BC Libraries Cooperative<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Toll-free: 1-888-848-9250<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><a href="mailto:Email%3Ajennifer.pringle@bc.libraries.coop" target="_blank">Email:jennifer.pringle@bc.libraries.coop</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Website: <a href="http://bc.libraries.coop" target="_blank">
<span style="color:rgb(70,120,134)">http://bc.libraries.coop</span></a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Gratefully acknowledging that I live and work in the unceded Traditional Territory of the St'at'yemc Nations.<u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11pt;font-family:Calibri,sans-serif">From:</span></b><span lang="EN-US" style="font-size:11pt;font-family:Calibri,sans-serif"> Evergreen-acq <<a href="mailto:evergreen-acq-bounces@list.evergreen-ils.org" target="_blank">evergreen-acq-bounces@list.evergreen-ils.org</a>>
<b>On Behalf Of </b>Tiffany Little via Evergreen-acq<br>
<b>Sent:</b> October 21, 2024 6:02 AM<br>
<b>To:</b> Evergreen ACQ Listserv <<a href="mailto:evergreen-acq@list.evergreen-ils.org" target="_blank">evergreen-acq@list.evergreen-ils.org</a>><br>
<b>Cc:</b> Tiffany Little <<a href="mailto:tlittle@georgialibraries.org" target="_blank">tlittle@georgialibraries.org</a>><br>
<b>Subject:</b> [Evergreen-acq] Fwd: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal"><span style="font-family:Tahoma,sans-serif">Good morning,<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Tahoma,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Tahoma,sans-serif">Good news! The bug that Mary brought up at our last meeting--where line items couldn't be true canceled--now has a fix! Thank you to Ian from Bibliomation for the fix, and to the New Devs group
for reviewing and creating unit tests for the problem.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Tahoma,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Tahoma,sans-serif">This is now Fix Committed for 3_13 and above (thanks Jane!).<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Tahoma,sans-serif"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-family:Tahoma,sans-serif">Tiffany<u></u><u></u></span></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12pt"><u></u> <u></u></p>
<table border="0" cellspacing="0" cellpadding="0" style="border-collapse:collapse">
<tbody>
<tr style="height:74.25pt">
<td valign="top" style="padding:0.75pt;height:74.25pt;overflow:hidden">
<p align="right" style="margin:0cm;text-align:right"><a href="https://georgialibraries.org/" target="_blank"><span style="font-size:11pt;font-family:Arial,sans-serif;color:rgb(17,85,204);border:1pt none windowtext;padding:0cm;text-decoration:none"><img border="0" width="75" height="75" style="width: 0.7797in; height: 0.7797in;" id="m_-5390723156629617995Picture_x0020_1" src="cid:ii_192afee9e9fbee2ed7e1" alt="Image removed by sender. logo with link to Georgia Public Library Service website"></span></a><span style="color:black"><u></u><u></u></span></p>
</td>
<td valign="top" style="padding:5pt;height:74.25pt;overflow:hidden">
<p style="margin:0cm"><b><span style="font-size:13pt;font-family:Verdana,sans-serif;color:rgb(30,67,155)">Tiffany Little</span></b><span style="color:black"><u></u><u></u></span></p>
<p style="margin:0cm"><b><span style="font-size:13pt;font-family:Verdana,sans-serif;color:rgb(30,67,155)">PINES Bibliographic Projects Manager</span></b><span style="color:black"><u></u><u></u></span></p>
<div class="MsoNormal" align="center" style="text-align:center"><span style="color:black">
<hr size="2" width="100%" align="center">
</span></div>
<p style="margin:0cm"><b><span style="font-family:Verdana,sans-serif;color:rgb(30,67,155)">Georgia Public Library Service</span></b><span style="color:black"><u></u><u></u></span></p>
<p style="margin:0cm"><span style="font-family:Verdana,sans-serif;color:rgb(30,67,155)">2872 Woodcock Blvd, Suite 250 | Atlanta, GA 30341</span><span style="color:black"><u></u><u></u></span></p>
<p style="margin:0cm"><span style="font-family:Verdana,sans-serif;color:rgb(30,67,155)">(404) 235-7161 |
<a href="mailto:tlittle@georgialibraries.org" target="_blank"><span style="color:rgb(17,85,204)">tlittle@georgialibraries.org</span></a></span><span style="color:black"><u></u><u></u></span></p>
</td>
</tr>
<tr style="height:36pt">
<td valign="top" style="padding:0.75pt;height:36pt;overflow:hidden">
</td>
<td valign="top" style="padding:5pt;height:36pt;overflow:hidden">
<p style="margin:0cm"><a href="https://www.facebook.com/georgialibraries" target="_blank"><span style="font-size:9pt;font-family:Verdana,sans-serif;color:rgb(17,85,204);border:1pt none windowtext;padding:0cm;text-decoration:none"><img border="0" width="36" height="36" style="width: 0.375in; height: 0.375in;" id="m_-5390723156629617995Picture_x0020_3" src="cid:ii_192afee9e9fbee2ed7e1" alt="Image removed by sender. logo with link to Georgia Public Library Service Facebook page"></span></a><a href="https://www.instagram.com/georgialibraries/" target="_blank"><b><span style="font-size:11pt;font-family:Verdana,sans-serif;color:rgb(17,85,204);border:1pt none windowtext;padding:0cm;text-decoration:none"><img border="0" width="34" height="34" style="width: 0.3571in; height: 0.3571in;" id="m_-5390723156629617995Picture_x0020_4" src="cid:ii_192afee9e9fbee2ed7e1" alt="Image removed by sender. logo with link to Georgia Public Library Service Instagram page"></span></b></a><a href="https://www.linkedin.com/company/georgia-public-library-service/" target="_blank"><span style="font-size:9pt;font-family:Verdana,sans-serif;color:rgb(17,85,204);border:1pt none windowtext;padding:0cm;text-decoration:none"><img border="0" width="36" height="36" style="width: 0.375in; height: 0.375in;" id="m_-5390723156629617995Picture_x0020_5" src="cid:ii_192afee9e9fbee2ed7e1" alt="Image removed by sender. logo with link to Georgia Public Library Service LinkedIn page"></span></a><a href="https://www.threads.net/@georgialibraries" target="_blank"><b><span style="font-size:11pt;font-family:Verdana,sans-serif;color:rgb(17,85,204);border:1pt none windowtext;padding:0cm;text-decoration:none"><img border="0" width="34" height="34" style="width: 0.3571in; height: 0.3571in;" id="m_-5390723156629617995Picture_x0020_6" src="cid:ii_192afee9e9fbee2ed7e1" alt="Image removed by sender. logo with link to Georgia Public Library Service Threads page"></span></b></a><span style="color:black"><u></u><u></u></span></p>
</td>
</tr>
<tr>
<td valign="top" style="padding:0.75pt;overflow:hidden"></td>
<td valign="top" style="padding:5pt;overflow:hidden">
<p style="margin:0cm"><span style="color:black"><a href="http://georgialibraries.org/subscription" target="_blank"><i><span style="font-size:11pt;font-family:Verdana,sans-serif;color:rgb(17,85,204)">Join our email list</span></i></a></span><i><span style="font-size:11pt;font-family:Verdana,sans-serif;color:black">
</span></i><i><span style="font-size:11pt;font-family:Verdana,sans-serif;color:rgb(67,67,67)">for stories of Georgia libraries making an impact in our communities.</span></i><span style="color:black"><u></u><u></u></span></p>
</td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12pt"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">---------- Forwarded message ---------<br>
From: <strong><span style="font-family:Aptos,sans-serif">Jane Sandberg</span></strong> <<a href="mailto:2084096@bugs.launchpad.net" target="_blank">2084096@bugs.launchpad.net</a>><br>
Date: Thu, Oct 17, 2024 at 12:05<span style="font-family:Arial,sans-serif"> </span>PM<br>
Subject: [Bug 2084096] Re: Line items cannot be canceled using a true cancel reason<br>
To: <<a href="mailto:tlittle@georgialibraries.org" target="_blank">tlittle@georgialibraries.org</a>><u></u><u></u></p>
</div>
<p class="MsoNormal" style="margin-bottom:12pt"><br>
<br>
Fix confirmed in yesterday's newdevs meeting. I've pushed this to<br>
rel_3_13 and above. Thanks, Ian, and all collaborators at yesterday's<br>
meeting!<br>
<br>
** Changed in: evergreen<br>
Assignee: Ian Skelskey (ianskelskey) => (unassigned)<br>
<br>
** Changed in: evergreen<br>
Status: Confirmed => Fix Committed<br>
<br>
** Also affects: evergreen/3.13<br>
Importance: Undecided<br>
Status: New<br>
<br>
** Changed in: evergreen<br>
Milestone: None => 3.14.1<br>
<br>
** Changed in: evergreen<br>
Milestone: 3.14.1 => 3.14.0<br>
<br>
** Changed in: evergreen/3.13<br>
Milestone: None => 3.13.5<br>
<br>
** Changed in: evergreen/3.13<br>
Importance: Undecided => High<br>
<br>
** Changed in: evergreen/3.13<br>
Status: New => Fix Committed<br>
<br>
** Tags added: pullrequest signedoff<br>
<br>
-- <br>
You received this bug notification because you are subscribed to the bug<br>
report.<br>
<a href="https://bugs.launchpad.net/bugs/2084096" target="_blank">https://bugs.launchpad.net/bugs/2084096</a><br>
<br>
Title:<br>
Line items cannot be canceled using a true cancel reason<br>
<br>
Status in Evergreen:<br>
Fix Committed<br>
Status in Evergreen 3.13 series:<br>
Fix Committed<br>
<br>
Bug description:<br>
Tested on a 3.14-beta and also seen on a 3.13 test server.<br>
<br>
Trying to cancel a line item with associated catalog items (eg copy<br>
ids) fails silently. There are two console error produced:<br>
<br>
open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:<br>
Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.<br>
<br>
<br>
ERROR Error: Uncaught (in promise): open-ils.acq.lineitem.cancel.batch failed! stat=500 msg= *** Call to [open-ils.acq.lineitem.cancel.batch] failed for session [0.363031297134109861728503116536], thread trace [0]:<br>
Can't call method "owning_lib" on an undefined value at /usr/local/share/perl/5.34.0/OpenILS/Application/Cat/AssetCommon.pm line 846.<br>
<br>
<br>
at resolvePromise (zone.js:1214:31)<br>
at resolvePromise (zone.js:1168:17)<br>
at zone.js:1281:17<br>
at _ZoneDelegate.invokeTask (zone.js:409:31)<br>
at core.mjs:23896:55<br>
at AsyncStackTaggingZoneSpec.onInvokeTask (core.mjs:23896:36)<br>
at _ZoneDelegate.invokeTask (zone.js:408:60)<br>
at Object.onInvokeTask (core.mjs:24197:33)<br>
at _ZoneDelegate.invokeTask (zone.js:408:60)<br>
at Zone.runTask (zone.js:178:47)<br>
<br>
<br>
To reproduce:<br>
1. Create a purchase order.<br>
2. Add a line item with item, estimated price, owning lib, shelving location and fund.<br>
3. Activate purchase order. Do *not* choose "Activate without loading items.<br>
4. Cancel the line item using a cancel reason that does not keep fund debits. (Cancel reason should start with "Canceled".)<br>
5. You will see the console error appear, but the page doesn't refresh and no error is given.<br>
<br>
This breaks a fundamental piece of Acquisitions, and is considered a<br>
acq blocker for 3.13 and 3.14 by the AIG.<br>
<br>
To manage notifications about this bug go to:<br>
<a href="https://bugs.launchpad.net/evergreen/+bug/2084096/+subscriptions" target="_blank">https://bugs.launchpad.net/evergreen/+bug/2084096/+subscriptions</a><u></u><u></u></p>
</div>
</div>
<p class="MsoNormal">This message originated from outside the M365 organisation. Please be careful with links, and don't trust messages you don't recognise.
<u></u><u></u></p>
</div>
</div>
_______________________________________________<br>
Evergreen-acq mailing list<br>
<a href="mailto:Evergreen-acq@list.evergreen-ils.org" target="_blank">Evergreen-acq@list.evergreen-ils.org</a><br>
<a href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-acq" rel="noreferrer" target="_blank">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-acq</a><br>
</div></blockquote></div><br clear="all"><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span><div dir="ltr" style="margin-left:0pt" align="left"><table style="border:none;border-collapse:collapse;table-layout:fixed;width:468pt"><colgroup><col><col width="492"></colgroup><tbody><tr style="height:0pt"><td style="border-width:1pt 1.5pt 1pt 1pt;border-style:solid;border-color:rgb(255,255,255) rgb(22,65,111) rgb(255,255,255) rgb(255,255,255);vertical-align:top;overflow:hidden"><br><span style="border:none;display:inline-block;overflow:hidden;width:139px;height:95px"><img src="https://lh7-us.googleusercontent.com/BTeYvD845QYnbO00n7bcW0mkegZXE2em5ARs9Wf2nWywbVWwERY-OX2hNhHa5Q2bUtHqfHmJqPsAmqE27SIVQB1EylOXG6umU4lTi_eVtiYgPCsvPRceJaJ5NIfnQt0g1zNfQ9Xzx1BQb4IXQfBr_h8" width="139" height="95" style="margin-left: 0px; margin-top: 0px;"></span></td><td style="border-width:1pt 1pt 1pt 1.5pt;border-style:solid;border-color:rgb(255,255,255) rgb(255,255,255) rgb(255,255,255) rgb(22,65,111);vertical-align:top;padding:12.168pt;overflow:hidden"><p dir="ltr" style="line-height:1.62;margin-top:0pt;margin-bottom:0pt"><span style="font-size:12pt;font-family:"Lucida Sans",sans-serif;color:rgb(22,65,111);background-color:transparent;font-weight:700;vertical-align:baseline">Carol Witt</span><span style="font-size:13.5pt;font-family:"Lucida Sans",sans-serif;color:rgb(22,65,111);background-color:transparent;font-weight:700;vertical-align:baseline"> </span><span style="font-size:10pt;font-family:"Lucida Sans",sans-serif;color:rgb(22,65,111);background-color:transparent;vertical-align:baseline">(she/her)</span><span style="font-size:13.5pt;font-family:"Lucida Sans",sans-serif;color:rgb(22,65,111);background-color:transparent;vertical-align:baseline"><br></span><span style="font-size:10pt;font-family:"Lucida Sans",sans-serif;color:rgb(33,33,33);background-color:transparent;vertical-align:baseline">Bibliographic Services Supervisor, C/W MARS, Inc.</span></p><p dir="ltr" style="line-height:1.62;margin-top:0pt;margin-bottom:0pt"></p><hr><p></p><p dir="ltr" style="line-height:0.891;margin:1pt"><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:20px;height:20px"><img alt="icon" src="https://lh7-us.googleusercontent.com/q2gbyNougapcDYhTiiAoMKelbfwl4oBcCuMyNmB7_bZgeRWYtCUSnQrPi8ab68yROW1C6B8se31KU4wjTYdlzuinue7h_Xi97ZJu6C6xr3EqCqgVazE_rD3pp-MYKD5TJaW_8Sso8VUemhZ3ZgWVK-k" width="20" height="20" style="margin-left: 0px; margin-top: 0px;"></span></span><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"> </span><a href="mailto:wittc@cwmars.org" target="_blank"><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(17,85,204);background-color:transparent;vertical-align:baseline">wittc@cwmars.org</span></a><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(0,0,0);background-color:transparent;font-weight:700;vertical-align:baseline"> | </span><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(0,0,0);background-color:transparent;font-weight:700;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:20px;height:20px"><img alt="icon" src="https://lh7-us.googleusercontent.com/GPO7gOK3AuNSm_waxnVGOu-PeKE-f640ESs-EXBt-eXrjP9hB2u1wmYQTJpmJLFLftYqtpCw8ltF6CBPooVqCLY5dgi3VYt9icN3ee_C9lFkhUm82tiw5ko3bHcS2TG__DE16fQw4l1VbUVjSZi7eMY" width="20" height="20" style="margin-left: 0px; margin-top: 0px;"></span></span><a href="https://www.cwmars.org/" target="_blank"><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(33,33,33);background-color:transparent;vertical-align:baseline">www.cwmars.org</span></a></p><p dir="ltr" style="line-height:0.891;margin:10pt 1pt 1pt"><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(0,0,0);background-color:transparent;font-weight:700;vertical-align:baseline"><span style="border:none;display:inline-block;overflow:hidden;width:20px;height:20px"><img alt="icon" src="https://lh7-us.googleusercontent.com/WVVHVDQPC1RdxWy1cXUgwZCioM6tDySYHtda3ZPPSC8CP1-_gc-0vQDpWNAIRX21VJAyP2mwtUcnLjE7ULN1Mz1rI_j2TUYPQ2HmeK666QOf-U-J4jFv3-hyLjW-ztWd5_wmzoXXDmi7P3fBnbrFc44" width="20" height="20" style="margin-left: 0px; margin-top: 0px;"></span></span><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(0,0,0);background-color:transparent;font-weight:700;vertical-align:baseline"> </span><span style="font-size:9pt;font-family:"Lucida Sans",sans-serif;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline">508-755-3323 x 3</span></p></td></tr></tbody></table></div></span></div></div>