[open-ils-commits] r7712 - trunk/Open-ILS/xul/staff_client/server/cat

svn at svn.open-ils.org svn at svn.open-ils.org
Thu Aug 23 13:11:59 EDT 2007


Author: phasefx
Date: 2007-08-23 13:06:55 -0400 (Thu, 23 Aug 2007)
New Revision: 7712

Modified:
   trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js
Log:
This makes the 'twisties' in the holdings maintenance interface default to a closed position (ie. the plus sign), and they'll sync up correctly with rows whether they're expanded or not, but, new bug??, if you toggle these rows open and close rapidly enough with mouseclicks, you can get a 'missed-click' where the toggle does not happen.  I tried tracing the behavior to pinpoint where exactly things go awry, but I'm giving up for now.. seems to be a minor bug, and the other display/render bug is fixed

Modified: trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js	2007-08-21 23:56:29 UTC (rev 7711)
+++ trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js	2007-08-23 17:06:55 UTC (rev 7712)
@@ -961,7 +961,7 @@
 			} else {
 				if (typeof org != 'object') org = obj.data.hash.aou[ org ];
 			}
-			obj.show_libs( org, true );
+			obj.show_libs( org, false );
 		
 			var p_org = obj.data.hash.aou[ org.parent_ou() ];
 			if (p_org) {
@@ -976,7 +976,7 @@
 					funcs.push(
 						function(o) {
 							return function() {
-								obj.show_libs( o, true );
+								obj.show_libs( o, false );
 							}
 						}( p_org.children()[i] )
 					);
@@ -1056,7 +1056,7 @@
 				funcs.push(
 					function(o) {
 						return function() {
-							obj.show_libs(o,true);
+							obj.show_libs(o,false);
 						}
 					}( orgs[i] )
 				);
@@ -1537,7 +1537,7 @@
 					'on_click' : function(ev) {
 						netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect UniversalBrowserRead');
 						var row = {}; var col = {}; var nobj = {};
-						obj.list.node.treeBoxObject.getCellAt(ev.clientX,ev.clientY,row,col,nobj);
+						obj.list.node.treeBoxObject.getCellAt(ev.clientX,ev.clientY,row,col,nobj); 
 						if ((row.value == -1)||(nobj.value != 'twisty')) { return; }
 						var node = obj.list.node.contentView.getItemAtIndex(row.value);
 						var list = [ node.getAttribute('retrieve_id') ];



More information about the open-ils-commits mailing list