[open-ils-commits] r8817 - branches/rel_1_2/Open-ILS/src/perlmods/OpenILS/Application

[svn at svn.open-ils.org]

Author: erickson
Date: 2008-02-22 10:18:51 -0500 (Fri, 22 Feb 2008)
New Revision: 8817

Modified:
   branches/rel_1_2/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
Log:
added logic to migrate holds from the deleted records to the master record in title merging

Modified: branches/rel_1_2/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
===================================================================
--- branches/rel_1_2/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm	2008-02-22 15:15:58 UTC (rev 8816)
+++ branches/rel_1_2/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm	2008-02-22 15:18:51 UTC (rev 8817)
@@ -766,8 +766,7 @@
 	signature	=> q/
 		Merges a group of records
 		@param auth The login session key
-		@param master The id of the record all other r
-			ecords should be merged into
+		@param master The id of the record all other records should be merged into
 		@param records Array of records to be merged into the master record
 		@return 1 on success, Event on error.
 	/
@@ -780,13 +779,49 @@
 	my $editor = new_editor( requestor => $reqr, xact => 1 );
 	my $v = OpenILS::Application::Cat::Merge::merge_records($editor, $master, $records);
 	return $v if $v;
-	$editor->finish;
-	return 1;
+	$editor->commit;
+    # tell the client the merge is complete, then merge the holds
+    $conn->respond_complete(1);
+    merge_holds($master, $records);
+	return undef;
 }
 
+sub merge_holds {
+    my($master, $records) = @_;
+    return unless $master and @$records;
+    return if @$records == 1 and $master == $$records[0];
 
+    my $e = new_editor(xact=>1);
+    my $holds = $e->search_action_hold_request(
+        {   cancel_time => undef, 
+            fulfillment_time => undef,
+            hold_type => 'T',
+            target => $records
+        },
+        {idlist=>1}
+    );
 
+    for my $hold_id (@$holds) {
 
+        my $hold = $e->retrieve_action_hold_request($hold_id);
+
+        $logger->info("Changing hold ".$hold->id.
+            " target from ".$hold->target." to $master in record merge");
+
+        $hold->target($master);
+        unless($e->update_action_hold_request($hold)) {
+            my $evt = $e->event;
+            $logger->error("Error updating hold ". $evt->textcode .":". $evt->desc .":". $evt->stacktrace); 
+        }
+    }
+
+    $e->commit;
+    return undef;
+}
+
+
+
+
 # ---------------------------------------------------------------------------
 # ---------------------------------------------------------------------------