[open-ils-commits] r11218 - in trunk/Open-ILS/xul/staff_client/server: cat circ
svn at svn.open-ils.org
svn at svn.open-ils.org
Sat Nov 15 23:40:42 EST 2008
Author: phasefx
Date: 2008-11-15 23:40:39 -0500 (Sat, 15 Nov 2008)
New Revision: 11218
Modified:
trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js
trunk/Open-ILS/xul/staff_client/server/cat/copy_buckets.js
trunk/Open-ILS/xul/staff_client/server/cat/record_buckets.js
trunk/Open-ILS/xul/staff_client/server/circ/copy_status.js
Log:
remove speedbumps since we authoritative methods now. This will affect folks who do gui scripting, like Brodart
Modified: trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js 2008-11-15 21:36:48 UTC (rev 11217)
+++ trunk/Open-ILS/xul/staff_client/server/cat/copy_browser.js 2008-11-16 04:40:39 UTC (rev 11218)
@@ -371,7 +371,6 @@
if (typeof robj.ilsevent != 'undefined') {
if ( (robj.ilsevent != 0) && (robj.ilsevent != 1227 /* COPY_DELETE_WARNING */) && (robj.ilsevent != 1208 /* TITLE_LAST_COPY */) ) throw(robj);
}
- alert(document.getElementById('catStrings').getString('staff.cat.copy_browser.delete_items.complete'));
obj.refresh_list();
}
Modified: trunk/Open-ILS/xul/staff_client/server/cat/copy_buckets.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/server/cat/copy_buckets.js 2008-11-15 21:36:48 UTC (rev 11217)
+++ trunk/Open-ILS/xul/staff_client/server/cat/copy_buckets.js 2008-11-16 04:40:39 UTC (rev 11218)
@@ -8,7 +8,6 @@
JSAN.use('util.network'); this.network = new util.network();
JSAN.use('util.date');
JSAN.use('OpenILS.data'); this.data = new OpenILS.data(); this.data.init({'via':'stash'});
- this.first_pause = true;
}
cat.copy_buckets.prototype = {
@@ -17,11 +16,6 @@
'bucket_id_name_map' : {},
'render_pending_copies' : function() {
- if (this.first_pause) {
- this.first_pause = false;
- } else {
- alert($('catStrings').getString('staff.cat.copy_buckets.render_pending_copies.complete'));
- }
var obj = this;
obj.list1.clear();
for (var i = 0; i < obj.copy_ids.length; i++) {
@@ -342,7 +336,6 @@
obj.error.standard_unexpected_error_alert($('catStrings').getString('staff.cat.copy_buckets.copy_buckets_delete_item.error'), E);
}
}
- alert($('catStrings').getString('staff.cat.copy_buckets.copy_buckets_delete_item.complete'));
setTimeout(
function() {
JSAN.use('util.widgets');
@@ -362,7 +355,6 @@
obj.list2.clear();
var robj = obj.network.simple_request('BUCKET_DELETE',[ses(),'copy',bucket]);
if (typeof robj == 'object') throw robj;
- alert($('catStrings').getString('staff.cat.copy_buckets.copy_buckets_delete_bucket.complete'));
obj.controller.render('copy_buckets_menulist_placeholder');
} catch(E) {
obj.error.standard_unexpected_error_alert($('catStrings').getString('staff.cat.copy_buckets.copy_buckets_delete_bucket.error'),E);
@@ -395,8 +387,6 @@
throw robj;
}
- alert($('catStrings').getFormattedString('staff.cat.copy_buckets.copy_buckets_new_bucket.success', [name]));
-
obj.controller.render('copy_buckets_menulist_placeholder');
obj.controller.view.bucket_menulist.value = robj;
setTimeout(
Modified: trunk/Open-ILS/xul/staff_client/server/cat/record_buckets.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/server/cat/record_buckets.js 2008-11-15 21:36:48 UTC (rev 11217)
+++ trunk/Open-ILS/xul/staff_client/server/cat/record_buckets.js 2008-11-16 04:40:39 UTC (rev 11218)
@@ -9,7 +9,6 @@
JSAN.use('util.network'); this.network = new util.network();
JSAN.use('util.date');
JSAN.use('OpenILS.data'); this.data = new OpenILS.data(); this.data.init({'via':'stash'});
- this.first_pause = true;
var x = document.getElementById("record_buckets_tabbox");
if (x) {
x.addEventListener(
@@ -96,11 +95,6 @@
'bucket_id_name_map' : {},
'render_pending_records' : function() {
- if (this.first_pause) {
- this.first_pause = false;
- } else {
- alert( $("commonStrings").getString('common.action_complete'));
- }
var obj = this;
obj.list1.clear();
for (var i = 0; i < obj.record_ids.length; i++) {
@@ -529,7 +523,6 @@
alert(js2JSON(E));
}
}
- alert( $("commonStrings").getString('common.action_complete'));
setTimeout(
function() {
JSAN.use('util.widgets');
@@ -549,7 +542,6 @@
obj.list2.clear();
var robj = obj.network.simple_request('BUCKET_DELETE',[ses(),'biblio',bucket]);
if (typeof robj == 'object') throw robj;
- alert( $("commonStrings").getString('common.action_complete'));
var x = document.getElementById('info_box');
x.setAttribute('hidden','true');
obj.controller.view.cmd_record_buckets_delete_bucket.setAttribute('disabled','true');
@@ -598,8 +590,6 @@
throw robj;
}
- alert($("catStrings").getFormattedString('staff.cat.record_buckets.new_bucket.bucket_created', [name]));
-
obj.controller.render('record_buckets_menulist_placeholder');
obj.controller.view.bucket_menulist.value = robj;
setTimeout(
@@ -721,8 +711,6 @@
);
if (typeof robj.ilsevent != 'undefined') {
throw(robj);
- } else {
- alert($("catStrings").getString('staff.cat.record_buckets.merge_records.success'));
}
obj.render_pending_records(); // FIXME -- need a generic refresh for lists
@@ -807,7 +795,7 @@
s += $("catStrings").getFormattedString('staff.cat.record_buckets.delete_records.s2', [record_ids[i], robj.textcode, robj.desc]);
}
}
- if (s) { alert(s); } else { alert($("catStrings").getString('staff.cat.record_buckets.delete_records.delete_success.alert')); }
+ if (s) { alert(s); }
obj.render_pending_records(); // FIXME -- need a generic refresh for lists
setTimeout(
Modified: trunk/Open-ILS/xul/staff_client/server/circ/copy_status.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/server/circ/copy_status.js 2008-11-15 21:36:48 UTC (rev 11217)
+++ trunk/Open-ILS/xul/staff_client/server/circ/copy_status.js 2008-11-16 04:40:39 UTC (rev 11218)
@@ -130,7 +130,6 @@
funcs.push( function(a) { return function() { obj.copy_status( a, true ); }; }(barcode) );
}
for (var i = 0; i < funcs.length; i++) { funcs[i](); }
- alert(document.getElementById('circStrings').getString('staff.circ.copy_status.action.complete'));
} catch(E) {
obj.error.standard_unexpected_error_alert(document.getElementById('circStrings').getString('staff.circ.copy_status.sel_checkin.error'),E);
}
@@ -152,7 +151,6 @@
}
}
for (var i = 0; i < funcs.length; i++) { funcs[i](); }
- alert(document.getElementById('circStrings').getString('staff.circ.copy_status.action.complete'));
} catch(E) {
obj.error.standard_unexpected_error_alert(document.getElementById('circStrings').getString('staff.circ.copy_status.cmd_replace_barcodes.error'), E);
}
@@ -199,7 +197,6 @@
funcs.push( function(a) { return function() { obj.copy_status( a, true ); }; }(barcode) );
}
for (var i = 0; i < funcs.length; i++) { funcs[i](); }
- alert(document.getElementById('circStrings').getString('staff.circ.copy_status.action.complete'));
}
],
'sel_patron' : [
@@ -234,7 +231,6 @@
}
}
for (var i = 0; i < funcs.length; i++) { funcs[i](); }
- alert(document.getElementById('circStrings').getString('staff.circ.copy_status.action.complete'));
}
],
More information about the open-ils-commits
mailing list