[open-ils-commits] r12873 - trunk/Open-ILS/src/c-apps (dbs)

svn at svn.open-ils.org svn at svn.open-ils.org
Tue Apr 14 23:20:34 EDT 2009


Author: dbs
Date: 2009-04-14 23:20:32 -0400 (Tue, 14 Apr 2009)
New Revision: 12873

Modified:
   trunk/Open-ILS/src/c-apps/oils_cstore.c
Log:
Enable field transforms to be named with a schema; is_identifier()
was being a bit too strict and killing perfectly good calls to
functions like "permission.usr_has_perm"


Modified: trunk/Open-ILS/src/c-apps/oils_cstore.c
===================================================================
--- trunk/Open-ILS/src/c-apps/oils_cstore.c	2009-04-15 01:47:25 UTC (rev 12872)
+++ trunk/Open-ILS/src/c-apps/oils_cstore.c	2009-04-15 03:20:32 UTC (rev 12873)
@@ -2673,6 +2673,8 @@
 	// metadata about the core search class
 	osrfHash* core_meta = NULL;
 
+	osrfLogDebug(OSRF_LOG_MARK, "cstore SELECT locale: %s", locale);
+
 	// punt if there's no core class
 	if (!join_hash || ( join_hash->type == JSON_HASH && !join_hash->size )) {
 		osrfLogError(
@@ -4800,13 +4802,15 @@
 
 	// Check each character until we reach white space or
 	// end-of-string.  Letters, digits, underscores, and 
-	// dollar signs are okay.  Control characters and other
+	// dollar signs are okay. With the exception of periods
+	// (as in schema.identifier), control characters and other
 	// punctuation characters are not okay.  Anything else
 	// is okay -- it could for example be part of a multibyte
 	// UTF8 character such as a letter with diacritical marks,
 	// and those are allowed.
 	do {
 		if( isalnum( (unsigned char) *s )
+			|| '.' == *s
 			|| '_' == *s
 			|| '$' == *s )
 			;  // Fine; keep going



More information about the open-ils-commits mailing list