[open-ils-commits] r15118 - trunk/Open-ILS/src/perlmods/OpenILS/Application (erickson)

[svn at svn.open-ils.org]

Author: erickson
Date: 2009-12-09 09:33:06 -0500 (Wed, 09 Dec 2009)
New Revision: 15118

Modified:
   trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
Log:
added some more inline comments for clarity

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm	2009-12-09 14:30:08 UTC (rev 15117)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm	2009-12-09 14:33:06 UTC (rev 15118)
@@ -2170,18 +2170,25 @@
 
 	if($api =~ /have_bill_or_payment/o) {
 
-        # includes xacts that have all-voided billings and at least 1 payment
+        # transactions that have a non-zero sum across all billings or at least 1 payment
 		@$mbts = grep { 
             int($_->balance_owed * 100) != 0 ||
             defined($_->last_payment_ts) } @$mbts;
 
     } elsif( $api =~ /have_balance/o) {
+
+        # transactions that have a non-zero overall balance
 		@$mbts = grep { int($_->balance_owed * 100) != 0 } @$mbts;
 
 	} elsif( $api =~ /have_charge/o) {
+
+        # transactions that have at least 1 billing, regardless of whether it was voided
 		@$mbts = grep { defined($_->last_billing_ts) } @$mbts;
 
 	} elsif( $api =~ /have_bill/o) {
+
+        # transactions that have non-zero sum across all billings.  This will exclude
+        # xacts where all billings have been voided
 		@$mbts = grep { int($_->total_owed * 100) != 0 } @$mbts;
 	}