[open-ils-commits] r15141 - trunk/Open-ILS/src/perlmods/OpenILS/Application (erickson)

[svn at svn.open-ils.org]

Author: erickson
Date: 2009-12-11 10:40:17 -0500 (Fri, 11 Dec 2009)
New Revision: 15141

Modified:
   trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
Log:
return null as the setting value when a user setting is not applied, instead of returning an empty string

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm	2009-12-11 15:01:00 UTC (rev 15140)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm	2009-12-11 15:40:17 UTC (rev 15141)
@@ -190,7 +190,7 @@
     sub get_setting {
         my($e, $user_id, $setting) = @_;
         my $val = $e->search_actor_user_setting({usr => $user_id, name => $setting})->[0];
-        return '' unless $val; # XXX this should really return undef, but needs testing
+        return undef unless $val; # XXX this should really return undef, but needs testing
         return OpenSRF::Utils::JSON->JSON2perl($val->value);
     }