[open-ils-commits] r11723 - trunk/Open-ILS/src/c-apps

[svn at svn.open-ils.org]

Author: miker
Date: 2009-01-02 12:47:31 -0500 (Fri, 02 Jan 2009)
New Revision: 11723

Modified:
   trunk/Open-ILS/src/c-apps/oils_cstore.c
Log:
changing opensrf response codes on general pcrud failure/denial for better client-side handling

Modified: trunk/Open-ILS/src/c-apps/oils_cstore.c
===================================================================
--- trunk/Open-ILS/src/c-apps/oils_cstore.c	2009-01-02 17:37:57 UTC (rev 11722)
+++ trunk/Open-ILS/src/c-apps/oils_cstore.c	2009-01-02 17:47:31 UTC (rev 11723)
@@ -842,7 +842,7 @@
         );
 
         char* m = buffer_release(msg);
-        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+        osrfAppSessionStatus( ctx->session, OSRF_STATUS_UNAUTHORIZED, "osrfMethodException", ctx->request, m );
 
         free(m);
         jsonObjectFree(user);
@@ -883,7 +883,7 @@
         );
 
         char* m = buffer_release(msg);
-        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+        osrfAppSessionStatus( ctx->session, OSRF_STATUS_FORBIDDEN, "osrfMethodException", ctx->request, m );
 
         free(m);
 
@@ -983,7 +983,7 @@
                 );
         
                 char* m = buffer_release(msg);
-                osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+                osrfAppSessionStatus( ctx->session, OSRF_STATUS_INTERNALSERVERERROR, "osrfMethodException", ctx->request, m );
         
                 free(m);
                 free(pkey_value);
@@ -1054,7 +1054,7 @@
                         );
                 
                         char* m = buffer_release(msg);
-                        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+                        osrfAppSessionStatus( ctx->session, OSRF_STATUS_INTERNALSERVERERROR, "osrfMethodException", ctx->request, m );
                         free(m);
                 
                         osrfStringArrayFree(class_list);
@@ -1493,12 +1493,12 @@
         growing_buffer* msg = buffer_init(128);
         buffer_fadd(
             msg,
-            "%s: Insufficient permissions",
+            "%s: Insufficient permissions to retrieve object",
             MODULENAME
         );
 
         char* m = buffer_release(msg);
-        osrfAppSessionStatus( ctx->session, OSRF_STATUS_BADREQUEST, "osrfMethodException", ctx->request, m );
+        osrfAppSessionStatus( ctx->session, OSRF_STATUS_NOTALLOWED, "osrfMethodException", ctx->request, m );
 
         free(m);