[open-ils-commits] r13574 - trunk/Open-ILS/web/reports/xul (dbs)
svn at svn.open-ils.org
svn at svn.open-ils.org
Mon Jul 13 12:24:01 EDT 2009
Author: dbs
Date: 2009-07-13 12:23:59 -0400 (Mon, 13 Jul 2009)
New Revision: 13574
Modified:
trunk/Open-ILS/web/reports/xul/source-setup.js
trunk/Open-ILS/web/reports/xul/utilities.js
Log:
Basic fix for reporter as of rel_1_6 and the super-smart cstore
As virtual fields are no longer defined in fm_IDL.xml, the old code that returned
a list of fields filtering on the virtual attribute started returning an empty list.
As a quick fix, we'll just return an array of all field elements.
Modified: trunk/Open-ILS/web/reports/xul/source-setup.js
===================================================================
--- trunk/Open-ILS/web/reports/xul/source-setup.js 2009-07-13 16:22:10 UTC (rev 13573)
+++ trunk/Open-ILS/web/reports/xul/source-setup.js 2009-07-13 16:23:59 UTC (rev 13574)
@@ -240,7 +240,7 @@
var fullpath = item.getAttribute('fullpath');
var reltype = item.getAttribute('reltype');
- var fields = filterByAttributeNS(c.getElementsByTagName('field'),persistNS, 'virtual','false');
+ var fields = nodelistToArray(c.getElementsByTagName('field'));
fields.sort( sortLabels );
var id = c.getAttribute('id');
Modified: trunk/Open-ILS/web/reports/xul/utilities.js
===================================================================
--- trunk/Open-ILS/web/reports/xul/utilities.js 2009-07-13 16:22:10 UTC (rev 13573)
+++ trunk/Open-ILS/web/reports/xul/utilities.js 2009-07-13 16:23:59 UTC (rev 13574)
@@ -80,4 +80,11 @@
return k;
}
-
+/* This just lets us return an array consistent with the filterBy* functions */
+function nodelistToArray (nodes) {
+ var aResponse = [];
+ for ( var i = 0; i < nodes.length; i++ ) {
+ aResponse.push(nodes[i]);
+ }
+ return aResponse;
+}
More information about the open-ils-commits
mailing list