[open-ils-commits] r13775 - trunk/Open-ILS/xul/staff_client/server/patron (phasefx)

[svn at svn.open-ils.org]

Author: phasefx
Date: 2009-07-29 05:31:15 -0400 (Wed, 29 Jul 2009)
New Revision: 13775

Modified:
   trunk/Open-ILS/xul/staff_client/server/patron/standing_penalties.js
Log:
This works either way.  list.append( row_params ) will return a modified row_params, but row_params is modified by reference in any case



Modified: trunk/Open-ILS/xul/staff_client/server/patron/standing_penalties.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/server/patron/standing_penalties.js	2009-07-29 09:11:58 UTC (rev 13774)
+++ trunk/Open-ILS/xul/staff_client/server/patron/standing_penalties.js	2009-07-29 09:31:15 UTC (rev 13775)
@@ -93,8 +93,7 @@
                     }
                 }
             };
-            rows[ xulG.patron.standing_penalties()[i].id() ] = function(p){ return p; }(row_params); // careful with vars in loops
-            list.append( row_params );
+            rows[ xulG.patron.standing_penalties()[i].id() ] = list.append( row_params );
         };
 
     } catch(E) {
@@ -160,8 +159,7 @@
                         }
                     }
                 };
-                rows[ penalty.id() ] = row_params;
-                list.append( row_params );
+                rows[ penalty.id() ] = list.append( row_params );
             }
             /*
             if (xulG && typeof xulG.refresh == 'function') {