[open-ils-commits] r13437 - branches/rel_1_4/Open-ILS/xul/staff_client/server/patron (phasefx)

[svn at svn.open-ils.org]

Author: phasefx
Date: 2009-06-23 08:59:25 -0400 (Tue, 23 Jun 2009)
New Revision: 13437

Modified:
   branches/rel_1_4/Open-ILS/xul/staff_client/server/patron/holds.js
Log:
the middle layer lets staff change the pickup lib of a hold already on the holds shelf if they have the UPDATE_PICKUP_LIB_FROM_HOLDS_SHELF permission.  It'll create a new transit.  So let the staff client allow it too

Modified: branches/rel_1_4/Open-ILS/xul/staff_client/server/patron/holds.js
===================================================================
--- branches/rel_1_4/Open-ILS/xul/staff_client/server/patron/holds.js	2009-06-23 12:59:20 UTC (rev 13436)
+++ branches/rel_1_4/Open-ILS/xul/staff_client/server/patron/holds.js	2009-06-23 12:59:25 UTC (rev 13437)
@@ -331,7 +331,7 @@
                                 var deny_edit_because_of_transit = false;
                                 for (var i = 0; i < obj.retrieve_ids.length; i++) {
                                     var hold = obj.holds_map[ obj.retrieve_ids[i].id ];
-                                    if (hold.status() > 2 /* Which means holds that are In-Transit or Ready for Pickup */) deny_edit_because_of_transit = true;
+                                    if (hold.status() == 3 /* In-Transit */) deny_edit_because_of_transit = true;
                                 }
                                 if (deny_edit_because_of_transit) {
                                     alert(document.getElementById('circStrings').getString('staff.circ.holds.error.may_not_edit_pickup_lib_for_hold_intransit'));