[open-ils-commits] r12360 - in trunk/Open-ILS/src/perlmods/OpenILS/Application: . Trigger (erickson)

[svn at svn.open-ils.org]

Author: erickson
Date: 2009-03-02 17:45:01 -0500 (Mon, 02 Mar 2009)
New Revision: 12360

Modified:
   trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
   trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm
   trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm
Log:
repairing var name typos/thinkos found with use strict

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm	2009-03-02 22:35:19 UTC (rev 12359)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm	2009-03-02 22:45:01 UTC (rev 12360)
@@ -184,6 +184,7 @@
     $self->editor->xact_begin || return undef;
 
     my @oks;
+    my $ok;
     for my $event ( @{ $self->events } ) {
         my $e = $self->editor->retrieve_action_trigger_event( $event->id );
         $e->start_time( 'now' ) unless $e->start_time;
@@ -223,16 +224,16 @@
     my $self = shift;
     my $env = $self->environment;
 
-    $$evn{target} = [];
-    $$evn{event} = [];
+    $$env{target} = [];
+    $$env{event} = [];
     for my $e ( @{ $self->events } ) {
-        for my $evn_part ( keys %{ $e->environment } ) {
+        for my $env_part ( keys %{ $e->environment } ) {
             if ($env_part eq 'target') {
-                push @{ $$evn{target} }, $e->environment->{target};
+                push @{ $$env{target} }, $e->environment->{target};
             } elsif ($env_part eq 'event') {
-                push @{ $$evn{event} }, $e->environment->{event};
+                push @{ $$env{event} }, $e->environment->{event};
             } else {
-                $$evn{$evn_part} = $e->environment->{$evn_part};
+                $$env{$env_part} = $e->environment->{$env_part};
             }
         }
     }

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm	2009-03-02 22:35:19 UTC (rev 12359)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm	2009-03-02 22:45:01 UTC (rev 12360)
@@ -57,7 +57,7 @@
     my $loaded = $m->use;
 
     if (!$loaded) {
-        $builtin_m = $self->prefix . "::$m";
+        my $builtin_m = $self->prefix . "::$m";
         $loaded = $builtin_m->use;
 
         if (!$loaded) {

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm	2009-03-02 22:35:19 UTC (rev 12359)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm	2009-03-02 22:45:01 UTC (rev 12360)
@@ -172,13 +172,13 @@
     for my $e_id ( @$events ) {
         my $e = OpenILS::Application::Trigger::Event->new($e_id);
         if ($e->validate->valid) {
-            if (my $group = $event->event->event_def->group_field) {
+            if (my $group = $e->event->event_def->group_field) {
 
                 # split the grouping link steps
                 my @steps = split '.', $group;
 
                 # find the grouping object
-                my $node = $event->target;
+                my $node = $e->target;
                 $node = $node->$_() for ( @steps );
 
                 # get the pkey value for the grouping object on this event