[open-ils-commits] r12438 - branches/rel_1_4_0/Open-ILS/web/reports/xul (miker)

svn at svn.open-ils.org svn at svn.open-ils.org
Fri Mar 6 08:42:46 EST 2009


Author: miker
Date: 2009-03-06 08:42:45 -0500 (Fri, 06 Mar 2009)
New Revision: 12438

Modified:
   branches/rel_1_4_0/Open-ILS/web/reports/xul/template-config.js
   branches/rel_1_4_0/Open-ILS/web/reports/xul/transforms.js
Log:
Patch from Jeff Godin:

The "First 5 characters" transform appears to be broken due to a typo,
patch attached. To fix previously broken templates created using this
transform, clone, re-select the First 5 characters transform on any fields
where you were using it, and save the template.

Also in this patch, change from confirm() to alert() for "Template NAME
was successfully saved." No point in using confirm(), nothing was checking
the return value, etc.



Modified: branches/rel_1_4_0/Open-ILS/web/reports/xul/template-config.js
===================================================================
--- branches/rel_1_4_0/Open-ILS/web/reports/xul/template-config.js	2009-03-06 13:42:19 UTC (rev 12437)
+++ branches/rel_1_4_0/Open-ILS/web/reports/xul/template-config.js	2009-03-06 13:42:45 UTC (rev 12438)
@@ -804,7 +804,7 @@
 				alertILSEvent(res);
 			} else {
 				if( res && res != '0' ) {
-					confirm(dojo.string.substitute( rpt_strings.TEMPLATE_CONF_SUCCESS_SAVE, [tmpl.name()] ));
+					alert(dojo.string.substitute( rpt_strings.TEMPLATE_CONF_SUCCESS_SAVE, [tmpl.name()] ));
 					_l('../oils_rpt.xhtml');
 				}
 			}

Modified: branches/rel_1_4_0/Open-ILS/web/reports/xul/transforms.js
===================================================================
--- branches/rel_1_4_0/Open-ILS/web/reports/xul/transforms.js	2009-03-06 13:42:19 UTC (rev 12437)
+++ branches/rel_1_4_0/Open-ILS/web/reports/xul/transforms.js	2009-03-06 13:42:45 UTC (rev 12438)
@@ -91,7 +91,7 @@
 		label : rpt_strings.TRANSFORMS_UPPER
 	},
 
-	firt5 : {
+	first5 : {
 		datatype : [ OILS_RPT_DTYPE_STRING ],
 		label : rpt_strings.TRANSFORMS_FIRST5
 	},



More information about the open-ils-commits mailing list