[open-ils-commits] r12521 - in trunk/Open-ILS/src/perlmods/OpenILS/Utils: . MFHD (djfiander)

[svn at svn.open-ils.org]

Author: djfiander
Date: 2009-03-14 11:03:03 -0400 (Sat, 14 Mar 2009)
New Revision: 12521

Modified:
   trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD.pm
   trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm
   trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm
Log:
Minor stylistic cleanups

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm	2009-03-14 14:54:42 UTC (rev 12520)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm	2009-03-14 15:03:03 UTC (rev 12521)
@@ -4,9 +4,8 @@
 use Carp;
 
 use DateTime;
-use MARC::Field;
 
-our @ISA = qw(MARC::Field);
+use base 'MARC::Field';
 
 sub new
 {
@@ -189,7 +188,7 @@
 # Initialize $weeknopat to be '(01|02|03|...|51|52|53)'
 $weeknopat = '(';
 foreach my $weekno (1..52) {
-    $weeknopat .= sprintf("%02d|", $weekno);
+    $weeknopat .= sprintf('%02d|', $weekno);
 }
 $weeknopat .= '53)';
 

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm	2009-03-14 14:54:42 UTC (rev 12520)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm	2009-03-14 15:03:03 UTC (rev 12521)
@@ -7,10 +7,8 @@
 
 use Data::Dumper;
 
-use MARC::Field;
+use base 'MARC::Field';
 
-our @ISA = qw(MARC::Field);
-
 sub new {
     my $proto = shift;
     my $class = ref($proto) || $proto;
@@ -119,7 +117,7 @@
 sub format {
     my $self = shift;
     my $caption = $self->{_mfhdh_CAPTION};
-    my $str = "";
+    my $str = '';
 
     if ($caption->enumeration_is_chronology) {
 	# if issues are identified by chronology only, then the
@@ -145,7 +143,7 @@
 		# a caption enclosed in parentheses is not displayed
 		$capstr = '';
 	    }
-	    $str .= ($key eq 'a' ? "" : ':') . $capstr . $self->{_mfhdh_SUBFIELDS}->{$key}->{HOLDINGS};
+	    $str .= ($key eq 'a' ? '' : ':') . $capstr . $self->{_mfhdh_SUBFIELDS}->{$key}->{HOLDINGS};
 	}
 
 	# Chronology

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD.pm	2009-03-14 14:54:42 UTC (rev 12520)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Utils/MFHD.pm	2009-03-14 15:03:03 UTC (rev 12521)
@@ -4,14 +4,11 @@
 use Carp;
 use Data::Dumper;
 
-use MARC::Record;
-use MFHD::Caption;
-use MFHD::Holding;
+use base 'MARC::Record';
 
-our @ISA;
+use OpenILS::Utils::MFHD::Caption;
+use OpenILS::Utils::MFHD::Holding;
 
- at ISA = qw(MARC::Record);
-
 sub new {
     my $proto = shift;
     my $class = ref($proto) || $proto;