[open-ils-commits] r14439 - trunk/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher (erickson)

[svn at svn.open-ils.org]

Author: erickson
Date: 2009-10-15 09:52:57 -0400 (Thu, 15 Oct 2009)
New Revision: 14439

Modified:
   trunk/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm
Log:
use inline penalty processing during fine generation to prevent duplicate penalties

Modified: trunk/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm	2009-10-15 02:51:45 UTC (rev 14438)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm	2009-10-15 13:52:57 UTC (rev 14439)
@@ -768,11 +768,18 @@
 
 			$self->method_lookup('open-ils.storage.transaction.commit')->run;
 
-			if(0) { # caluclate penalties inline.  Needs to be tested.
+			if(1) { 
+
+                # Caluclate penalties inline
 				OpenILS::Utils::Penalty->calculate_penalties(
 					undef, $c->usr->to_fieldmapper->id.'', $c->circ_lib->to_fieldmapper->id.'');
+
 			} else {
 
+                # Calculate penalties with an aysnc call to the penalty server.  This approach
+                # may lead to duplicate penalties since multiple penalty processes for a
+                # given user may be running at the same time. Leave this here for reference 
+                # in case we later find that asyc calls are needed in some environments.
 				$penalty->request(
 				    'open-ils.penalty.patron_penalty.calculate',
 				    { patronid	=> ''.$c->usr,