[open-ils-commits] r14154 - branches/rel_1_4_0/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher (miker)

[svn at svn.open-ils.org]

Author: miker
Date: 2009-09-24 13:10:18 -0400 (Thu, 24 Sep 2009)
New Revision: 14154

Modified:
   branches/rel_1_4_0/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm
Log:
SQL thinko causing over-zealous reshelving of copies not yet out of their delay time.  Problem spotted and fix suggested by Bill Ott of GRPL.

Modified: branches/rel_1_4_0/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm
===================================================================
--- branches/rel_1_4_0/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm	2009-09-24 17:08:55 UTC (rev 14153)
+++ branches/rel_1_4_0/Open-ILS/src/perlmods/OpenILS/Application/Storage/Publisher/action.pm	2009-09-24 17:10:18 UTC (rev 14154)
@@ -149,8 +149,8 @@
 			   FROM $cp cp 
                     LEFT JOIN $setting setting
                         ON (cp.circ_lib = setting.org_unit AND setting.name = 'circ.reshelving_complete.interval')
-                    LEFT JOIN $circ circ ON (circ.target_copy = cp.id AND circ.id IS NULL)
-              WHERE cp.status = 7
+                    LEFT JOIN $circ circ ON (circ.target_copy = cp.id)
+              WHERE cp.status = 7 AND circ.id IS NULL
                     AND cp.create_date < NOW() - CAST( COALESCE( BTRIM( setting.value,'"' ), ? )  AS INTERVAL)
           )
 	SQL