[open-ils-commits] r17184 - branches/rel_1_6_0/Open-ILS/web/opac/skin/default/js (dbs)

svn at svn.open-ils.org svn at svn.open-ils.org
Thu Aug 12 03:46:06 EDT 2010


Author: dbs
Date: 2010-08-12 03:46:01 -0400 (Thu, 12 Aug 2010)
New Revision: 17184

Modified:
   branches/rel_1_6_0/Open-ILS/web/opac/skin/default/js/rdetail.js
Log:
Remove broken old JavaScript in Google Book preview code

I /think/ this was supposed to change the title of the "Preview" link to
"Read this online" or the like in the case that the full text is available,
but it was relying on a function that didn't exist (setText) and trying
to reference an ID that didn't exists. So it broke in those rare cases
where Google Books did provide the full text.


Modified: branches/rel_1_6_0/Open-ILS/web/opac/skin/default/js/rdetail.js
===================================================================
--- branches/rel_1_6_0/Open-ILS/web/opac/skin/default/js/rdetail.js	2010-08-12 07:45:11 UTC (rev 17183)
+++ branches/rel_1_6_0/Open-ILS/web/opac/skin/default/js/rdetail.js	2010-08-12 07:46:01 UTC (rev 17184)
@@ -1024,11 +1024,6 @@
 	}
 
 	if ( GBPBook.preview != "noview" ) {
-		if ( GBPBook.preview == 'full' ) {
-			setText( $('rdetail_preview_link'), $('rdetail_preview_full_text').innerHTML );
-			$('rdetail_preview_link_a').title = $('rdetail_preview_title').innerHTML;      
-		}
-
 		// Add a button below the book cover image to load the preview.
 		GBPBadge = document.createElement( 'img' );
 		GBPBadge.src = 'http://books.google.com/intl/en/googlebooks/images/gbs_preview_button1.gif';



More information about the open-ils-commits mailing list