[open-ils-commits] r15517 - trunk/Open-ILS/web/js/dojo/fieldmapper (miker)
svn at svn.open-ils.org
svn at svn.open-ils.org
Fri Feb 12 11:17:34 EST 2010
Author: miker
Date: 2010-02-12 11:17:31 -0500 (Fri, 12 Feb 2010)
New Revision: 15517
Modified:
trunk/Open-ILS/web/js/dojo/fieldmapper/dojoData.js
Log:
Addressing https://bugs.launchpad.net/evergreen/+bug/520632 -- not strictly required here, but for(;;) is better form for array access
Modified: trunk/Open-ILS/web/js/dojo/fieldmapper/dojoData.js
===================================================================
--- trunk/Open-ILS/web/js/dojo/fieldmapper/dojoData.js 2010-02-12 16:11:46 UTC (rev 15516)
+++ trunk/Open-ILS/web/js/dojo/fieldmapper/dojoData.js 2010-02-12 16:17:31 UTC (rev 15517)
@@ -26,10 +26,10 @@
function _fromStoreItem (data) {
this.fromHash(data);
- for (var i in this._ignore_fields)
+ for (var i = 0; i < this._ignore_fields.length; i++)
this[this._ignore_fields[i]](null);
- for ( var i=0; i < this._fields.length; i++) {
+ for (var i = 0; i < this._fields.length; i++) {
if (dojo.isArray( this[this._fields[i]]() ))
this[this._fields[i]]( this[this._fields[i]]()[0] );
}
@@ -53,22 +53,22 @@
if (!params) params = {};
var data = this.initStoreData(label, params);
- for (var i in list) data.items.push( list[i].toHash(true, params.virtualFields) );
+ for (var i = 0; i < list.length; i++) data.items.push( list[i].toHash(true, params.virtualFields) );
if (params.children && params.parent) {
var _hash_list = data.items;
var _find_root = {};
- for (var i in _hash_list) {
+ for (var i = 0; i < _hash_list.length; i++) {
_find_root[_hash_list[i][params.identifier]] = _hash_list[i];
}
var item_data = [];
- for (var i in _hash_list) {
+ for (var i = 0; i < _hash_list.length; i++) {
var obj = _hash_list[i]
obj[params.children] = [];
- for (var j in _hash_list) {
+ for (var j = 0; j < _hash_list.length; j++) {
var kid = _hash_list[j];
if (kid[params.parent] == obj[params.identifier]) {
obj[params.children].push( { _reference : kid[params.identifier] } );
@@ -80,7 +80,7 @@
item_data.push( obj );
}
- for (var j in _find_root) {
+ for (var j = 0; j < _find_root.length; j++) {
_find_root[j]['_top'] = 'true';
if (!_find_root[j][params.parent])
_find_root[j]['_trueRoot'] = 'true';
More information about the open-ils-commits
mailing list