[open-ils-commits] r15519 - trunk/Open-ILS/web/js/dojo/fieldmapper (miker)

svn at svn.open-ils.org svn at svn.open-ils.org
Fri Feb 12 11:23:10 EST 2010


Author: miker
Date: 2010-02-12 11:23:07 -0500 (Fri, 12 Feb 2010)
New Revision: 15519

Modified:
   trunk/Open-ILS/web/js/dojo/fieldmapper/OrgUtils.js
Log:
Addressing https://bugs.launchpad.net/evergreen/+bug/520632 -- not strictly required here, but for(;;) is better form for array access

Modified: trunk/Open-ILS/web/js/dojo/fieldmapper/OrgUtils.js
===================================================================
--- trunk/Open-ILS/web/js/dojo/fieldmapper/OrgUtils.js	2010-02-12 16:22:47 UTC (rev 15518)
+++ trunk/Open-ILS/web/js/dojo/fieldmapper/OrgUtils.js	2010-02-12 16:23:07 UTC (rev 15519)
@@ -37,7 +37,7 @@
 
 		var types = fieldmapper.standardRequest(['open-ils.actor','open-ils.actor.org_types.retrieve']);
 
-		for (var i in types) {
+		for (var i = 0; i < types.length; i++) {
 			fieldmapper.aout.OrgTypeCache[types[i].id()] = {
 				loaded : true,
 				type : types[i]
@@ -63,7 +63,7 @@
 	fieldmapper.aou.findOrgUnit = fieldmapper.aou.LoadOrg;
 
 	if (window._l) {
-		for (var i in _l) {
+		for (var i = 0; i < _l.length; i++) {
 			fieldmapper.aou.OrgCache[_l[i][0]] = {
 				loaded: false,
 				org : new fieldmapper.aou().fromHash({
@@ -91,7 +91,7 @@
 			fieldmapper.aou.OrgCache[x.id()].treePtr = x;
 		}
 
-		for (var i in globalOrgTypes) {
+		for (var i = 0; i < globalOrgTypes.length; i++) {
 			fieldmapper.aout.OrgTypeCache[globalOrgTypes[i].id()] = {
 				loaded : true,
 				type : globalOrgTypes[i]



More information about the open-ils-commits mailing list