[open-ils-commits] r15365 - in trunk/Open-ILS/xul/staff_client: . chrome/content/main defaults/preferences external (phasefx)

[svn at svn.open-ils.org]

Author: phasefx
Date: 2010-01-22 10:40:55 -0500 (Fri, 22 Jan 2010)
New Revision: 15365

Added:
   trunk/Open-ILS/xul/staff_client/external/developers.js
Modified:
   trunk/Open-ILS/xul/staff_client/Makefile.am
   trunk/Open-ILS/xul/staff_client/chrome/content/main/main.js
   trunk/Open-ILS/xul/staff_client/defaults/preferences/prefs.js
Log:
Make developer-oriented preferences for the staff client optional, since some of them can impact performance.

I couldn't figure out how to get something like

	make DEBUG=1 build  

to work, so I went with

	make devbuild



Modified: trunk/Open-ILS/xul/staff_client/Makefile.am
===================================================================
--- trunk/Open-ILS/xul/staff_client/Makefile.am	2010-01-22 14:30:00 UTC (rev 15364)
+++ trunk/Open-ILS/xul/staff_client/Makefile.am	2010-01-22 15:40:55 UTC (rev 15365)
@@ -22,6 +22,9 @@
 
 install-exec-local: $(OILSSERVER_INST)
 
+devbuild: build
+	@cp external/developers.js build/defaults/preferences/
+
 build: build_dir chrome2remote localize_manifest generated custom_skins open-ils stamp 
 	@echo To test the staff client:
 	@echo "  cd build/"

Modified: trunk/Open-ILS/xul/staff_client/chrome/content/main/main.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/chrome/content/main/main.js	2010-01-22 14:30:00 UTC (rev 15364)
+++ trunk/Open-ILS/xul/staff_client/chrome/content/main/main.js	2010-01-22 15:40:55 UTC (rev 15365)
@@ -297,8 +297,11 @@
             document.getElementById('debug_gb').hidden = false;
         }
 
-        if (G.pref && G.pref.getBoolPref('open-ils.debug_options')) {
-            document.getElementById('debug_gb').hidden = false;
+        try {
+            if (G.pref && G.pref.getBoolPref('open-ils.debug_options')) {
+                document.getElementById('debug_gb').hidden = false;
+            }
+        } catch(E) {
         }
 
         window.title = authStrings.getFormattedString('staff.auth.titlebar.label', version);

Modified: trunk/Open-ILS/xul/staff_client/defaults/preferences/prefs.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/defaults/preferences/prefs.js	2010-01-22 14:30:00 UTC (rev 15364)
+++ trunk/Open-ILS/xul/staff_client/defaults/preferences/prefs.js	2010-01-22 15:40:55 UTC (rev 15365)
@@ -48,17 +48,6 @@
 pref("privacy.popups.disable_from_plugins",0);
 pref("privacy.popups.policy",0);
 
-// Developer options
-pref("browser.dom.window.dump.enabled",true);
-pref("javascript.options.strict",false);
-pref("javascript.options.showInConsole",true);
-pref("nglayout.debug.disable_xul_cache",false);
-pref("nglayout.debug.disable_xul_fastload",false);
-pref("browser.xul.error_pages.enabled",true);
-// This one is specific for Open-ILS; debug options on login window
-pref("open-ils.debug_options", true);
-
-
 pref("browser.download.useDownloadDir", true);
 pref("browser.download.folderList", 0);
 pref("browser.download.manager.showAlertOnComplete", true);
@@ -71,6 +60,8 @@
 pref("browser.download.manager.focusWhenStarting", false);
 pref("browser.download.manager.flashCount", 2); 
 
+// Developer options we want for all builds
+pref("browser.dom.window.dump.enabled",true);
 
 // For extension manager, etc.
 pref("xpinstall.dialog.confirm", "chrome://mozapps/content/xpinstall/xpinstallConfirm.xul");

Added: trunk/Open-ILS/xul/staff_client/external/developers.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/external/developers.js	                        (rev 0)
+++ trunk/Open-ILS/xul/staff_client/external/developers.js	2010-01-22 15:40:55 UTC (rev 15365)
@@ -0,0 +1,14 @@
+// Developer options
+pref("browser.dom.window.dump.enabled",true);
+pref("javascript.options.strict",true);
+pref("javascript.options.showInConsole",true);
+pref("nglayout.debug.disable_xul_cache",true);
+pref("nglayout.debug.disable_xul_fastload",true);
+pref("browser.xul.error_pages.enabled",true);
+pref("extensions.logging.enabled",true);
+pref("dom.report_all_js_exceptions",true);
+// This one is specific for Open-ILS; debug options on login window
+pref("open-ils.debug_options", true);
+
+
+