[open-ils-commits] r15751 - trunk/Open-ILS/src/c-apps (scottmk)

svn at svn.open-ils.org svn at svn.open-ils.org
Mon Mar 8 23:53:55 EST 2010


Author: scottmk
Date: 2010-03-08 23:53:52 -0500 (Mon, 08 Mar 2010)
New Revision: 15751

Modified:
   trunk/Open-ILS/src/c-apps/oils_cstore.c
Log:
Fix a NULL pointer problem that, under some circumstances, could segfault.

The get_primitive() function was returning NULL in some cases, and the calling
code didn't check for NULL.

Fix: return "string" as the default datatype.

M    Open-ILS/src/c-apps/oils_cstore.c


Modified: trunk/Open-ILS/src/c-apps/oils_cstore.c
===================================================================
--- trunk/Open-ILS/src/c-apps/oils_cstore.c	2010-03-09 03:47:04 UTC (rev 15750)
+++ trunk/Open-ILS/src/c-apps/oils_cstore.c	2010-03-09 04:53:52 UTC (rev 15751)
@@ -5979,8 +5979,7 @@
 				MODULENAME,
 				osrfHashGet( field, "name" )
 			);
-		else
-			s = "string";
+		s = "string";
 	}
 	return s;
 }



More information about the open-ils-commits mailing list