[open-ils-commits] r16426 - in trunk/Open-ILS/web: js/ui/default/acq/search opac/locale/en-US (senator)

[svn at svn.open-ils.org]

Author: senator
Date: 2010-05-13 11:02:58 -0400 (Thu, 13 May 2010)
New Revision: 16426

Modified:
   trunk/Open-ILS/web/js/ui/default/acq/search/unified.js
   trunk/Open-ILS/web/opac/locale/en-US/lang.dtd
Log:
Acq: two bug fixes

1) a bug recently introduced in unified search would try to build the catalog
search query more often than needed (and fail at it)
2) there was a colliding accesskey in staff client acquisitions menu


Modified: trunk/Open-ILS/web/js/ui/default/acq/search/unified.js
===================================================================
--- trunk/Open-ILS/web/js/ui/default/acq/search/unified.js	2010-05-13 14:23:14 UTC (rev 16425)
+++ trunk/Open-ILS/web/js/ui/default/acq/search/unified.js	2010-05-13 15:02:58 UTC (rev 16426)
@@ -546,10 +546,14 @@
             var widget = this.widgets[id];
 
             if (!sso[attr]) sso[attr] = [];
+            var  value = (
+                typeof(widget.attr) == "function" ?
+                    widget.attr("value") : widget.value
+            );
+            if (typeof(value) != "string")
+                value = value.join(" || ");
             sso[attr].push(
-                (match_how.indexOf("__not") == -1 ? "" : "-") +
-                (typeof(widget.attr) == "function" ?
-                    widget.attr("value").join(" || ") : widget.value)
+                (match_how.indexOf("__not") == -1 ? "" : "-") + value
             );
         }
         var ssa = [];
@@ -681,16 +685,16 @@
             "&c=" + dojo.byId("acq-unified-conjunction").getValue();
     };
 
-    this.search = function(search_object, bib_search_string) {
+    this.search = function(search_object, termManager) {
         var count_results = 0;
-        var bibs_too = false;
+        var bib_search_string = null;
         var result_type = dojo.byId("acq-unified-result-type").getValue();
         var conjunction = dojo.byId("acq-unified-conjunction").getValue();
 
         /* lineitem_and_bib: a special case */
         if (result_type == "lineitem_and_bib") {
             result_type = "lineitem";
-            bibs_too = true;
+            bib_search_string = termManager.buildBibSearchString();
         }
 
         function result_completion() {
@@ -723,7 +727,7 @@
                     }
                 },
                 "oncomplete": function() {
-                    if (bibs_too) {
+                    if (bib_search_string) {
                         fieldmapper.standardRequest(
                             ["open-ils.acq",
                                 "open-ils.acq.biblio.wrapped_search"], {
@@ -788,9 +792,7 @@
             hideForm();
             openils.Util.show("acq-unified-body");
             termManager.reflect(uriManager.search_object);
-            resultManager.search(
-                uriManager.search_object, termManager.buildBibSearchString()
-            );
+            resultManager.search(uriManager.search_object, termManager);
         } else {
             termManager.addRow();
             openils.Util.show("acq-unified-body");

Modified: trunk/Open-ILS/web/opac/locale/en-US/lang.dtd
===================================================================
--- trunk/Open-ILS/web/opac/locale/en-US/lang.dtd	2010-05-13 14:23:14 UTC (rev 16425)
+++ trunk/Open-ILS/web/opac/locale/en-US/lang.dtd	2010-05-13 15:02:58 UTC (rev 16426)
@@ -822,7 +822,7 @@
 <!ENTITY staff.main.menu.acq.provider.label "Providers">
 <!ENTITY staff.main.menu.acq.provider.accesskey "V">
 <!ENTITY staff.main.menu.acq.edi_account.label "EDI Accounts">
-<!ENTITY staff.main.menu.acq.edi_account.accesskey "A">
+<!ENTITY staff.main.menu.acq.edi_account.accesskey "U">
 <!ENTITY staff.main.menu.acq.distrib_formula.label "Distribution Formulas">
 <!ENTITY staff.main.menu.acq.distrib_formula.accesskey "D">
 <!ENTITY staff.main.menu.acq.currency_type.label "Currency Types">