[open-ils-commits] r18126 - in trunk/Open-ILS/src/sql/Pg: . upgrade (dbs)
svn at svn.open-ils.org
svn at svn.open-ils.org
Fri Oct 1 16:08:05 EDT 2010
Author: dbs
Date: 2010-10-01 16:07:59 -0400 (Fri, 01 Oct 2010)
New Revision: 18126
Added:
trunk/Open-ILS/src/sql/Pg/upgrade/0424.schema.circ_due_date_trigger.sql
Modified:
trunk/Open-ILS/src/sql/Pg/002.schema.config.sql
trunk/Open-ILS/src/sql/Pg/090.schema.action.sql
Log:
Set due times for durations measured in days to 23:59:59 after inserts OR updates
The existing trigger acted only on the initial insert of a circulation
transaction for duration intervals perfectly divisible by 24 hours.
If updates to those due dates were subsequently issued, then the due
time would revert to 00:00:00 - which could cause surprising overdue
fines to be generated on the due date, rather than after the due date.
This commit makes the trigger take effect on both INSERT and UPDATE
to the action.circulation table.
Modified: trunk/Open-ILS/src/sql/Pg/002.schema.config.sql
===================================================================
--- trunk/Open-ILS/src/sql/Pg/002.schema.config.sql 2010-10-01 19:46:18 UTC (rev 18125)
+++ trunk/Open-ILS/src/sql/Pg/002.schema.config.sql 2010-10-01 20:07:59 UTC (rev 18126)
@@ -70,7 +70,7 @@
install_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT NOW()
);
-INSERT INTO config.upgrade_log (version) VALUES ('0423'); -- miker
+INSERT INTO config.upgrade_log (version) VALUES ('0424'); -- dbs
CREATE TABLE config.bib_source (
id SERIAL PRIMARY KEY,
Modified: trunk/Open-ILS/src/sql/Pg/090.schema.action.sql
===================================================================
--- trunk/Open-ILS/src/sql/Pg/090.schema.action.sql 2010-10-01 19:46:18 UTC (rev 18125)
+++ trunk/Open-ILS/src/sql/Pg/090.schema.action.sql 2010-10-01 20:07:59 UTC (rev 18126)
@@ -164,7 +164,7 @@
END;
$$ LANGUAGE PLPGSQL;
-CREATE TRIGGER push_due_date_tgr BEFORE INSERT ON action.circulation FOR EACH ROW EXECUTE PROCEDURE action.push_circ_due_time();
+CREATE TRIGGER push_due_date_tgr BEFORE INSERT OR UPDATE ON action.circulation FOR EACH ROW EXECUTE PROCEDURE action.push_circ_due_time();
CREATE TABLE action.aged_circulation (
usr_post_code TEXT,
Added: trunk/Open-ILS/src/sql/Pg/upgrade/0424.schema.circ_due_date_trigger.sql
===================================================================
--- trunk/Open-ILS/src/sql/Pg/upgrade/0424.schema.circ_due_date_trigger.sql (rev 0)
+++ trunk/Open-ILS/src/sql/Pg/upgrade/0424.schema.circ_due_date_trigger.sql 2010-10-01 20:07:59 UTC (rev 18126)
@@ -0,0 +1,9 @@
+BEGIN;
+
+INSERT INTO config.upgrade_log (version) VALUES ('0424'); -- dbs
+
+DROP TRIGGER push_due_date_tgr ON action.circulation;
+
+CREATE TRIGGER push_due_date_tgr BEFORE INSERT OR UPDATE ON action.circulation FOR EACH ROW EXECUTE PROCEDURE action.push_circ_due_time();
+
+COMMIT;
More information about the open-ils-commits
mailing list