[open-ils-commits] r18129 - branches/rel_1_6/Open-ILS/src/sql/Pg (dbs)

[svn at svn.open-ils.org]

Author: dbs
Date: 2010-10-01 16:18:38 -0400 (Fri, 01 Oct 2010)
New Revision: 18129

Modified:
   branches/rel_1_6/Open-ILS/src/sql/Pg/090.schema.action.sql
   branches/rel_1_6/Open-ILS/src/sql/Pg/1.6.1-1.6.2-upgrade-db.sql
Log:
Set due times for durations measured in days to 23:59:59 after inserts OR updates

The existing trigger acted only on the initial insert of a circulation
transaction for duration intervals perfectly divisible by 24 hours.
If updates to those due dates were subsequently issued, then the due
time would revert to 00:00:00 - which could cause surprising overdue
fines to be generated on the due date, rather than after the due date.

This commit makes the trigger take effect on both INSERT and UPDATE
to the action.circulation table.


Modified: branches/rel_1_6/Open-ILS/src/sql/Pg/090.schema.action.sql
===================================================================
--- branches/rel_1_6/Open-ILS/src/sql/Pg/090.schema.action.sql	2010-10-01 20:13:10 UTC (rev 18128)
+++ branches/rel_1_6/Open-ILS/src/sql/Pg/090.schema.action.sql	2010-10-01 20:18:38 UTC (rev 18129)
@@ -140,7 +140,7 @@
 END;
 $$ LANGUAGE PLPGSQL;
 
-CREATE TRIGGER push_due_date_tgr BEFORE INSERT ON action.circulation FOR EACH ROW EXECUTE PROCEDURE action.push_circ_due_time();
+CREATE TRIGGER push_due_date_tgr BEFORE INSERT OR UPDATE ON action.circulation FOR EACH ROW EXECUTE PROCEDURE action.push_circ_due_time();
 
 CREATE TABLE action.aged_circulation (
 	usr_post_code		TEXT,

Modified: branches/rel_1_6/Open-ILS/src/sql/Pg/1.6.1-1.6.2-upgrade-db.sql
===================================================================
--- branches/rel_1_6/Open-ILS/src/sql/Pg/1.6.1-1.6.2-upgrade-db.sql	2010-10-01 20:13:10 UTC (rev 18128)
+++ branches/rel_1_6/Open-ILS/src/sql/Pg/1.6.1-1.6.2-upgrade-db.sql	2010-10-01 20:18:38 UTC (rev 18129)
@@ -5,4 +5,8 @@
 ALTER TABLE asset.copy_location ADD COLUMN label_prefix TEXT;
 ALTER TABLE asset.copy_location ADD COLUMN label_suffix TEXT;
 
+-- Push due dates to 23:59:59 on insert OR update
+DROP TRIGGER push_due_date_tgr ON action.circulation;
+CREATE TRIGGER push_due_date_tgr BEFORE INSERT OR UPDATE ON action.circulation FOR EACH ROW EXECUTE PROCEDURE action.push_circ_due_time();
+
 COMMIT;