[open-ils-commits] r17447 - trunk/Open-ILS/src/perlmods/OpenILS/Application (senator)

[svn at svn.open-ils.org]

Author: senator
Date: 2010-09-02 14:45:28 -0400 (Thu, 02 Sep 2010)
New Revision: 17447

Modified:
   trunk/Open-ILS/src/perlmods/OpenILS/Application/Booking.pm
Log:
Circ/Booking: replace checks for the CAPTURE_RESERVATION permission with
checks for COPY_CHECKIN

There's no such permission as CAPTURE_HOLD, so why should reservations be
different?  Also, testing for reservations to capture during normal checkin
was making trouble for users if they didn't have CAPTURE_RESERVATION.


Modified: trunk/Open-ILS/src/perlmods/OpenILS/Application/Booking.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/Application/Booking.pm	2010-09-02 17:35:46 UTC (rev 17446)
+++ trunk/Open-ILS/src/perlmods/OpenILS/Application/Booking.pm	2010-09-02 18:45:28 UTC (rev 17447)
@@ -791,7 +791,7 @@
 
     my $e = new_editor("authtoken" => $auth);
     return $e->die_event unless $e->checkauth;
-    return $e->die_event unless $e->allowed("CAPTURE_RESERVATION");
+    return $e->die_event unless $e->allowed("COPY_CHECKIN");
 
     my $dt_parser = new DateTime::Format::ISO8601;
     my $now = now DateTime; # sic
@@ -940,7 +940,7 @@
 
     my $e = new_editor(authtoken => $auth);
     return $e->die_event unless $e->checkauth;
-    return $e->die_event unless $e->allowed("CAPTURE_RESERVATION");
+    return $e->die_event unless $e->allowed("COPY_CHECKIN");
 
     my $uncaptured = get_uncaptured_bresv_for_brsrc(
         $e, {"barcode" => $barcode}
@@ -987,7 +987,7 @@
 
     my $e = new_editor("xact" => 1, "authtoken" => $auth);
     return $e->die_event unless $e->checkauth;
-    return $e->die_event unless $e->allowed('CAPTURE_RESERVATION');
+    return $e->die_event unless $e->allowed("COPY_CHECKIN");
     my $here = $e->requestor->ws_ou;
 
     my $reservation = $e->retrieve_booking_reservation([