[open-ils-commits] r17476 - trunk/Open-ILS/web/js/dojo/MARC (miker)

svn at svn.open-ils.org svn at svn.open-ils.org
Fri Sep 3 13:30:40 EDT 2010


Author: miker
Date: 2010-09-03 13:30:36 -0400 (Fri, 03 Sep 2010)
New Revision: 17476

Modified:
   trunk/Open-ILS/web/js/dojo/MARC/Field.js
   trunk/Open-ILS/web/js/dojo/MARC/Record.js
Log:
we should really just use for(;;) for arguments

Modified: trunk/Open-ILS/web/js/dojo/MARC/Field.js
===================================================================
--- trunk/Open-ILS/web/js/dojo/MARC/Field.js	2010-09-03 16:39:13 UTC (rev 17475)
+++ trunk/Open-ILS/web/js/dojo/MARC/Field.js	2010-09-03 17:30:36 UTC (rev 17476)
@@ -47,7 +47,7 @@
         },
 
         addSubfields : function () {
-            for (var i in arguments) {
+            for (var i = 0; i < arguments.length; i++) {
                 var code = arguments[i];
                 var value = arguments[++i];
                 this.subfields.push( [ code, value ] );

Modified: trunk/Open-ILS/web/js/dojo/MARC/Record.js
===================================================================
--- trunk/Open-ILS/web/js/dojo/MARC/Record.js	2010-09-03 16:39:13 UTC (rev 17475)
+++ trunk/Open-ILS/web/js/dojo/MARC/Record.js	2010-09-03 17:30:36 UTC (rev 17476)
@@ -68,7 +68,7 @@
 
         insertOrderedFields : function () {
             var me = this;
-            for ( var i in arguments ) { // arguments is special, and for..in is correct
+            for (var i = 0; i < arguments.length; i++) {
                 var f = arguments[i];
                 var done = false;
                 for (var j = 0; j < this.fields.length; j++) {



More information about the open-ils-commits mailing list