[open-ils-commits] r18111 - trunk/Open-ILS/src/perlmods/OpenILS/SIP (atz)

[svn at svn.open-ils.org]

Author: atz
Date: 2010-09-30 19:06:39 -0400 (Thu, 30 Sep 2010)
New Revision: 18111

Modified:
   trunk/Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm
Log:
Silence warning

Warnings was:
Use of uninitialized value in subroutine entry at /openils/lib/perl5/OpenILS/SIP/Patron.pm line 230.

Signed-off-by: Joe Atzberger <atz at esilibrary.com>

Modified: trunk/Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm	2010-09-30 20:49:46 UTC (rev 18110)
+++ trunk/Open-ILS/src/perlmods/OpenILS/SIP/Patron.pm	2010-09-30 23:06:39 UTC (rev 18111)
@@ -221,20 +221,19 @@
     return $self->{user}->card->active eq 'f';
 }
 
-sub recall_overdue {
+sub recall_overdue {        # not implemented
     my $self = shift;
     return 0;
 }
 
-
 sub check_password {
 	my ($self, $pwd) = @_;
 	syslog('LOG_DEBUG', 'OILS: Patron->check_password()');
-	return $pwd and (md5_hex($pwd) eq $self->{user}->passwd);
+    return 0 unless (defined $pwd and $self->{user});
+	return md5_hex($pwd) eq $self->{user}->passwd;
 }
 
-
-sub currency {
+sub currency {              # not really implemented
 	my $self = shift;
 	syslog('LOG_DEBUG', 'OILS: Patron->currency()');
 	return 'USD';
@@ -283,12 +282,12 @@
 	return 'OK';
 }
 
-sub print_line {
+sub print_line {            # not implemented
     my $self = shift;
 	return '';
 }
 
-sub too_many_charged {
+sub too_many_charged {      # not implemented
     my $self = shift;
 	return 0;
 }