[open-ils-commits] r20101 - in trunk/Open-ILS/src/sql/Pg: . upgrade (miker)

[svn at svn.open-ils.org]

Author: miker
Date: 2011-04-15 11:38:13 -0400 (Fri, 15 Apr 2011)
New Revision: 20101

Modified:
   trunk/Open-ILS/src/sql/Pg/030.schema.metabib.sql
   trunk/Open-ILS/src/sql/Pg/upgrade/0517.schema.multiple-9s-in-856.sql
Log:
thinko in for-in-array loop, uncovered by error testing from Ben Shum

Modified: trunk/Open-ILS/src/sql/Pg/030.schema.metabib.sql
===================================================================
--- trunk/Open-ILS/src/sql/Pg/030.schema.metabib.sql	2011-04-15 14:49:34 UTC (rev 20100)
+++ trunk/Open-ILS/src/sql/Pg/030.schema.metabib.sql	2011-04-15 15:38:13 UTC (rev 20101)
@@ -853,7 +853,9 @@
                     SELECT id INTO uri_id FROM asset.uri WHERE label = uri_label AND href = uri_href AND use_restriction = uri_use AND active;
                 END IF;
 
-                 FOR uri_owner IN 1 .. ARRAY_UPPER(uri_owner_list, 1) LOOP
+                FOR j IN 1 .. ARRAY_UPPER(uri_owner_list, 1) LOOP
+                    uri_owner := uri_owner_list[j];
+
                     SELECT id INTO uri_owner_id FROM actor.org_unit WHERE shortname = uri_owner;
                     CONTINUE WHEN NOT FOUND;
     

Modified: trunk/Open-ILS/src/sql/Pg/upgrade/0517.schema.multiple-9s-in-856.sql
===================================================================
--- trunk/Open-ILS/src/sql/Pg/upgrade/0517.schema.multiple-9s-in-856.sql	2011-04-15 14:49:34 UTC (rev 20100)
+++ trunk/Open-ILS/src/sql/Pg/upgrade/0517.schema.multiple-9s-in-856.sql	2011-04-15 15:38:13 UTC (rev 20101)
@@ -52,7 +52,9 @@
                     SELECT id INTO uri_id FROM asset.uri WHERE label = uri_label AND href = uri_href AND use_restriction = uri_use AND active;
                 END IF;
 
-                 FOR uri_owner IN 1 .. ARRAY_UPPER(uri_owner_list, 1) LOOP
+                FOR j IN 1 .. ARRAY_UPPER(uri_owner_list, 1) LOOP
+                    uri_owner := uri_owner_list[j];
+
                     SELECT id INTO uri_owner_id FROM actor.org_unit WHERE shortname = uri_owner;
                     CONTINUE WHEN NOT FOUND;