[open-ils-commits] r20335 - trunk/Open-ILS/src/perlmods/lib/OpenILS/WWW (dbs)

[svn at svn.open-ils.org]

Author: dbs
Date: 2011-04-27 08:16:15 -0400 (Wed, 27 Apr 2011)
New Revision: 20335

Modified:
   trunk/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
Log:
Consolidate on checking for integers for -full / -uris

The check for an integer when $flesh eq 'uris' was throwing errors
and breaking authority browsing; rather than complicating matters
further, use an explicit integer for the return value when the format
ends with "-uris" so that we can simply test for an integer value
greater than 0.

Signed-off-by: Dan Scott <dscott at laurentian.ca>


Modified: trunk/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm	2011-04-27 01:47:22 UTC (rev 20334)
+++ trunk/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm	2011-04-27 12:16:15 UTC (rev 20335)
@@ -273,7 +273,7 @@
 The feed type could end with the string "-full", in which case we want
 to return call numbers, copies, and URIS.
 
-Or the feed type could be "-uris", in which case we want to return
+Or the feed type could end with "-uris", in which case we want to return
 call numbers and URIS.
 
 Otherwise, we won't return any holdings.
@@ -288,7 +288,7 @@
     }
 
      if ($type =~ /-uris$/o) {
-        return "uris";
+        return 2;
     }
 
     # Otherwise, we'll return just the facts, ma'am
@@ -1491,8 +1491,8 @@
 
         $node->id($item_tag);
         #$node->update_ts(cleanse_ISO8601($record->edit_date));
-        $node->link(alternate => $feed->unapi . "?id=$item_tag&format=htmlholdings-full" => 'text/html') if ($flesh > 0 || $flesh eq 'uris');
-        $node->link(opac => $feed->unapi . "?id=$item_tag&format=opac") if ($flesh > 0 || $flesh eq 'uris');
+        $node->link(alternate => $feed->unapi . "?id=$item_tag&format=htmlholdings-full" => 'text/html') if ($flesh > 0);
+        $node->link(opac => $feed->unapi . "?id=$item_tag&format=opac") if ($flesh > 0);
         $node->link(unapi => $feed->unapi . "?id=$item_tag") if ($flesh);
         $node->link('unapi-id' => $item_tag) if ($flesh);
     }