[open-ils-commits] [GIT] Evergreen ILS branch rel_2_1 updated. f88489b7e480ef6187b1cc91dfaab6d24ae449fd

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_1 has been updated
       via  f88489b7e480ef6187b1cc91dfaab6d24ae449fd (commit)
      from  d868562abdc1b2d44af879956a24208d037037d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f88489b7e480ef6187b1cc91dfaab6d24ae449fd
Author: Jason Etheridge <jason at esilibrary.com>
Date:   Mon Aug 15 15:34:07 2011 -0400

    LP#820409 fix org unit admin UI
    
    This reverts part of 17e659eec3e23caf5d301b33aa5019b672ecd0e8, which was
    tightening checks against null and '' to avoid implicit type-casting.
    
    This line var modified_ou = new aou().fromStoreItem( current_ou ); was
    producing a fieldmapper object where certain fields were being set to
    contain the string "undefined" rather than a null.
    
    The update method would take isdeleted == "undefined" as True.
    
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/web/js/dojo/fieldmapper/Fieldmapper.js b/Open-ILS/web/js/dojo/fieldmapper/Fieldmapper.js
index bb369c6..d8eb4b7 100644
--- a/Open-ILS/web/js/dojo/fieldmapper/Fieldmapper.js
+++ b/Open-ILS/web/js/dojo/fieldmapper/Fieldmapper.js
@@ -215,7 +215,7 @@ if(!dojo._hasResource["fieldmapper.Fieldmapper"]){
     //** FROM HASH **/
     function _fromHash (_hash) {
         for ( var i=0; i < this._fields.length; i++) {
-            if (_hash[this._fields[i]] !== null)
+            if (_hash[this._fields[i]] != null)
                 this[this._fields[i]]( _hash[this._fields[i]] );
         }
         return this;
@@ -225,8 +225,8 @@ if(!dojo._hasResource["fieldmapper.Fieldmapper"]){
         var _hash = {};
         var i;
         for (i=0; i < this._fields.length; i++) {
-            if (includeNulls || this[this._fields[i]]() !== null) {
-                if (this[this._fields[i]]() === null)
+            if (includeNulls || this[this._fields[i]]() != null) {
+                if (this[this._fields[i]]() == null)
                     _hash[this._fields[i]] = null;
                 else
                     _hash[this._fields[i]] = '' + this[this._fields[i]]();

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/dojo/fieldmapper/Fieldmapper.js |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Evergreen ILS