[open-ils-commits] r19161 - branches/rel_2_0/Open-ILS/web/js/ui/default/acq/invoice (gmc)

svn at svn.open-ils.org svn at svn.open-ils.org
Tue Jan 11 18:18:49 EST 2011


Author: gmc
Date: 2011-01-11 18:18:43 -0500 (Tue, 11 Jan 2011)
New Revision: 19161

Modified:
   branches/rel_2_0/Open-ILS/web/js/ui/default/acq/invoice/view.js
Log:
allow deletion of incomplete invoice LIs

Fix silent failure when attempting to delete a LI
whose type or cost was not set; dojo.string.subtitute
does not like replacement values to be null.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Modified: branches/rel_2_0/Open-ILS/web/js/ui/default/acq/invoice/view.js
===================================================================
--- branches/rel_2_0/Open-ILS/web/js/ui/default/acq/invoice/view.js	2011-01-11 23:18:21 UTC (rev 19160)
+++ branches/rel_2_0/Open-ILS/web/js/ui/default/acq/invoice/view.js	2011-01-11 23:18:43 UTC (rev 19161)
@@ -385,8 +385,8 @@
         var cost = widgetRegistry.acqii[item.id()].cost_billed.getFormattedValue();
         var msg = dojo.string.substitute(
             localeStrings.INVOICE_CONFIRM_ITEM_DELETE, [
-                cost,
-                widgetRegistry.acqii[item.id()].inv_item_type.getFormattedValue()
+                cost || 0,
+                widgetRegistry.acqii[item.id()].inv_item_type.getFormattedValue() || ''
             ]
         );
         if(!confirm(msg)) return;



More information about the open-ils-commits mailing list