[open-ils-commits] [GIT] Evergreen ILS branch master updated. e1bfdad900674c4f9e4859cfdd11cb6c19209318

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  e1bfdad900674c4f9e4859cfdd11cb6c19209318 (commit)
      from  08b13c6648eb9316baaeb84c5b2bfcaa39e2f72a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e1bfdad900674c4f9e4859cfdd11cb6c19209318
Author: Dan Scott <dan at coffeecode.net>
Date:   Fri Jun 24 10:44:43 2011 -0400

    Fix broken images for items without ISBNs in search results
    
    The search results code happily sets the src attribute of the cover
    image to an empty string (as returned by cleanISBN()) if currentISBN has
    not been defined (which is generally the case if an item doesn't have an
    ISBN, such as a DVD or a thesis or an old book).
    
    Protect against the empty string and set the src attribute to
    '/opac/images/blank.png' to avoid broken image indicators in search
    results.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/web/opac/skin/default/js/result_common.js b/Open-ILS/web/opac/skin/default/js/result_common.js
index 6a5d8c3..31edb3b 100644
--- a/Open-ILS/web/opac/skin/default/js/result_common.js
+++ b/Open-ILS/web/opac/skin/default/js/result_common.js
@@ -501,8 +501,12 @@ function resultDisplayRecord(rec, pos, is_mr) {
 	} catch(e){ }
 */
 
-	var pic = $n(r, config.names.result.item_jacket);
-	pic.setAttribute("src", buildISBNSrc(currentISBN));
+    var pic = $n(r, config.names.result.item_jacket);
+    if (currentISBN) {
+        pic.setAttribute("src", buildISBNSrc(currentISBN));
+    } else {
+        pic.setAttribute("src", "/opac/images/blank.png");
+    }
 
 	var title_link = $n(r, config.names.result.item_title);
 	var author_link = $n(r, config.names.result.item_author);

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/opac/skin/default/js/result_common.js |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS