[open-ils-commits] r19639 - trunk/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ (dbwells)

[svn at svn.open-ils.org]

Author: dbwells
Date: 2011-03-08 14:15:01 -0500 (Tue, 08 Mar 2011)
New Revision: 19639

Modified:
   trunk/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
Log:
Address LP bug #724583, "Paying Bills with Patron Credit does not always decrease patron Credit"


Modified: trunk/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
===================================================================
--- trunk/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm	2011-03-07 21:20:12 UTC (rev 19638)
+++ trunk/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm	2011-03-08 19:15:01 UTC (rev 19639)
@@ -323,11 +323,11 @@
         my $amount = $payment->amount;
         my $transid = $payment->xact;
         my $trans = $xacts{$transid};
+        # making payment with existing patron credit.
+        $credit -= $amount if $type eq 'credit_payment';
         if( (my $cred = ($trans->balance_owed - $amount)) <= 0 ) {
             # Any overpay on this transaction goes directly into patron
-            # credit making payment with existing patron credit.
-            $credit -= $amount if $type eq 'credit_payment';
-
+            # credit
             $cred = -$cred;
             $credit += $cred;
             my $circ = $e->retrieve_action_circulation($transid);