[open-ils-commits] r20371 - trunk/Open-ILS/xul/staff_client/server/admin (phasefx)

svn at svn.open-ils.org svn at svn.open-ils.org
Mon May 2 10:05:58 EDT 2011


Author: phasefx
Date: 2011-05-02 10:05:56 -0400 (Mon, 02 May 2011)
New Revision: 20371

Modified:
   trunk/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js
Log:
Fix bug and typo in stat cat editor

Specifically, disabling the ability to select a stat cat type on no permissions on current type.

If you don't have permissions on ASSET you could never get to ACTOR.

If you picked ACTOR without rights you couldn't get back to ASSET.

Also, re-enable the library selector and new buttons when you do change to one you can add for.

Author: Thomas Berezansky <tsbere at mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere at mvlc.org>
Signed-off-by: Jason Etheridge <jason at esilibrary.com>


Modified: trunk/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js
===================================================================
--- trunk/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js	2011-05-02 13:21:38 UTC (rev 20370)
+++ trunk/Open-ILS/xul/staff_client/server/admin/stat_cat_editor.js	2011-05-02 14:05:56 UTC (rev 20371)
@@ -52,7 +52,7 @@
     PERMS[ASSET].update_stat_cat_entry =  OILS_WORK_PERMS.UPDATE_COPY_STAT_CAT_ENTRY;
     PERMS[ASSET].delete_stat_cat_entry =  OILS_WORK_PERMS.DELETE_COPY_STAT_CAT_ENTRY;
 
-    // set up the fitler select
+    // set up the filter select
     var fselector = $('sc_org_filter');
     var org_list = PERMS[currentlyVisible].update_stat_cat;
     buildMergedOrgSel(fselector, org_list, 0, 'shortname');
@@ -296,10 +296,13 @@
     var org_list = PERMS[type].create_stat_cat;
     if(org_list.length == 0) { /* no create perms */
         $('sc_new').disabled = true;
-        typeSel.disabled = true;
         libSel.disabled = true;
         return;
     }
+    else {
+        $('sc_new').disabled = false;
+        libSel.disabled = false;
+    }
     buildMergedOrgSel(libSel, org_list, 0, 'shortname');
 }
 



More information about the open-ils-commits mailing list