[open-ils-commits] [GIT] Evergreen ILS branch rel_2_0 updated. 9ee51d00965663034ca8b9673d4447d5fd8b2e7e

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_0 has been updated
       via  9ee51d00965663034ca8b9673d4447d5fd8b2e7e (commit)
      from  02b6bc50ae6df2ea06cede9f77f88dc1a074bf0c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9ee51d00965663034ca8b9673d4447d5fd8b2e7e
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Wed May 18 17:26:58 2011 -0400

    Add permission checking for updating and deleting volumes.
    
    This addresses LP #784062 reported by Ben Shum, and I think others?
    
    Creating volumes was already covered.  The ability to delete volumes
    without permission would be less often an issue in practice since you
    would need permission to delete the volume's copies before you could
    delete the volume itself.
    
    Anyway, this should square things.
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm b/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
index 4d68812..4a9c12e 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Cat.pm
@@ -751,6 +751,8 @@ sub fleshed_volume_update {
 		if( $vol->isdeleted ) {
 
 			$logger->info("vol-update: deleting volume");
+			return $editor->event unless
+				$editor->allowed('UPDATE_VOLUME', $vol->owning_lib);
 			my $cs = $editor->search_asset_copy(
 				{ call_number => $vol->id, deleted => 'f' } );
 			return OpenILS::Event->new(
@@ -795,6 +797,9 @@ sub update_volume {
 	my $evt;
     my $merge_vol;
 
+    return {evt => $editor->event} unless
+        $editor->allowed('UPDATE_VOLUME', $vol->owning_lib);
+
 	return {evt => $evt} 
         if ( $evt = OpenILS::Application::Cat::AssetCommon->org_cannot_have_vols($editor, $vol->owning_lib) );
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/OpenILS/Application/Cat.pm |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS