[open-ils-commits] [GIT] Evergreen ILS branch master updated. 25c2dbe0ad7b9f642181dd504d58e87790ad6a8f

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  25c2dbe0ad7b9f642181dd504d58e87790ad6a8f (commit)
      from  4a13d896946250245e6866357c1b2ce134c01417 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 25c2dbe0ad7b9f642181dd504d58e87790ad6a8f
Author: James Fournie <jfournie at sitka.bclibraries.ca>
Date:   Tue Nov 1 16:01:57 2011 -0700

    This prevents the acq unified_search method from returning anything other
    than the objects of the expected type.
    
    This is to address LP 884991 in which Acq users get a perm error for each
    result of a search that they don't have access to retrieve.  They shouldn't
    even know about the existence of anything they don't have access to retrieve.
    
    Signed-off-by: James Fournie <jfournie at sitka.bclibraries.ca>
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Search.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Search.pm
index b6f267c..6e2d854 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Search.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Search.pm
@@ -462,7 +462,11 @@ q/order_by clause must be of the long form, like:
     if ($options->{"id_list"}) {
         $conn->respond($_) foreach @id_list;
     } else {
-        $conn->respond($retriever->($e, $_, $options)) foreach @id_list;
+        foreach(@id_list){
+            my $resp = $retriever->($e, $_, $options);
+            next if(ref($resp) ne "Fieldmapper::acq::$ret_type");
+            $conn->respond($resp);
+        }
     }
 
     $e->disconnect;

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Application/Acq/Search.pm |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS