[open-ils-commits] [GIT] Evergreen ILS branch master updated. ef82b6171473d9f4c705e5bd1db592d72746ae2d

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  ef82b6171473d9f4c705e5bd1db592d72746ae2d (commit)
      from  935535bb17a25d9cc862137a0fea58bfd59352f4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ef82b6171473d9f4c705e5bd1db592d72746ae2d
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Mon Oct 31 11:46:48 2011 -0400

    lp849447: trival stylistic tweaks
    
    - rename variable avoid double-negative
    - avoid 'Variable declared in conditional statement' perlcritic gripe
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index 4c1323c..d2b2085 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -287,13 +287,13 @@ sub charge_ok {
     # determine whether patron should be allowed to circulate materials:
     # not barred, doesn't owe too much wrt fines/fees, privileges haven't
     # expired
-    my $no_circ = 't' if
+    my $circ_is_blocked = 
         (($u->barred eq 't') or
          ($u->standing_penalties and @{$u->standing_penalties}) or
          (CORE::time > $expire->epoch));
 
     return
-        !$no_circ and
+        !$circ_is_blocked and
         $u->active eq 't' and
         $u->card->active eq 't';
 }

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS