[open-ils-commits] [GIT] Evergreen ILS branch master updated. 2e0f3937a7053f25560c79daead9e008d108d5d2
Evergreen Git
git at git.evergreen-ils.org
Tue Oct 11 10:15:33 EDT 2011
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".
The branch, master has been updated
via 2e0f3937a7053f25560c79daead9e008d108d5d2 (commit)
via c4fba0c28826d0f6b3e1e31ad9c5d8f4ead1041f (commit)
from bb6451c5644167a42de43a4106d93199232bb1af (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2e0f3937a7053f25560c79daead9e008d108d5d2
Author: Galen Charlton <gmc at esilibrary.com>
Date: Sun Sep 25 22:58:32 2011 -0400
fix another POD glitch
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Dan Scott <dscott at laurentian.ca>
diff --git a/Open-ILS/tests/datasets/edi_scratch/baker_taylor.ordrsp.jedi.pl b/Open-ILS/tests/datasets/edi_scratch/baker_taylor.ordrsp.jedi.pl
index 6e2c62e..bbd86d5 100644
--- a/Open-ILS/tests/datasets/edi_scratch/baker_taylor.ordrsp.jedi.pl
+++ b/Open-ILS/tests/datasets/edi_scratch/baker_taylor.ordrsp.jedi.pl
@@ -1,4 +1,4 @@
-=doc
+=head1 EDIFACT ORDRSP message
UNA:+.? 'UNB+UNOC:3+1556150:31B+123EVER:31B+100622:1004+03'UNG+ORDRSP+1556150:31B+123EVER:31B+100622:1004+38+UN+D 'UNH+03+ORDRSP:D:96A:UN'BGM+231+071678+29+AC'DTM+137:20100622:102'RFF+ON:8'NAD+BY+123EVER::9'NAD+BY+123EVER 0001::91'CUX+2:USD:9'LIN+1+5+9780446360272:EN'IMD+F+BST+:::NOT APPLIC WEBSTERS NEW WORLD THESA'QTY+21:10'QTY+12:10'QTY+85:0'FTX+LIN++01:8B:28'PRI+AAB:4.5::SRP'RFF+LI:8/1'LIN+2+5+9780446357197:EN'IMD+F+BST+:::COLLINS, J WORLD IS FULL OF DIVORCE'QTY+21:8'QTY+12:8'QTY+85:0'FTX+LIN++01:8B:28'PRI+AAB:6.5::SRP'RFF+LI:8/2'LIN+3+5+9780446350105:EN'IMD+F+BST+:::SHELDON, S WINDMILLS OF THE GODS'QTY+21:5'QTY+12:5'QTY+85:0'FTX+LIN++01:8B:28'PRI+AAB:6.99::SRP'RFF+LI:8/3'UNS+S'CNT+2:3'UNT+34+03'UNE+1+38'UNZ+1+03'
commit c4fba0c28826d0f6b3e1e31ad9c5d8f4ead1041f
Author: Galen Charlton <gmc at esilibrary.com>
Date: Sun Sep 25 22:51:56 2011 -0400
fix up POD
- avoids some noise when building the Perl modules for
distributions that check for correctness when converting
POD to man pages
- add a an author test, taken straight from the Test::Pod
documentation, for POD correctness
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Dan Scott <dscott at laurentian.ca>
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Picklist.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Picklist.pm
index eee578f..eacdaaa 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Picklist.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Picklist.pm
@@ -381,8 +381,10 @@ sub retrieve_pl_lineitem {
return undef;
}
-=head comment
+=head1 comment
+
request open-ils.cstore open-ils.cstore.json_query.atomic {"select":{"jub":[{"transform":"count", "attregate":1, "column":"id","alias":"count"}]}, "from":"jub","where":{"picklist":1}}
+
=cut
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher.pm
index fb685d6..658fa22 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher.pm
@@ -463,7 +463,7 @@ for my $fmclass ( (Fieldmapper->classes) ) {
);
}
-=comment
+=head1 comment
unless ( __PACKAGE__->is_registered( $api_prefix.'.search_like' ) ) {
__PACKAGE__->register_method(
@@ -570,7 +570,7 @@ for my $fmclass ( (Fieldmapper->classes) ) {
);
}
-=comment
+=head1 comment
unless ( __PACKAGE__->is_registered( $api_prefix.'.search_like.'.$field ) ) {
__PACKAGE__->register_method(
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/biblio.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/biblio.pm
index b6dd586..65a777a 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/biblio.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/biblio.pm
@@ -241,7 +241,7 @@ __PACKAGE__->register_method(
);
-=comment Old version
+=head1 comment Old version
my $org_unit_lookup;
sub record_copy_count {
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm
index 03237ca..48c6e39 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm
@@ -129,7 +129,8 @@ sub checkauth {
return $self->{requestor} = $content->{userobj};
}
-=head test
+=head1 test
+
sub checkauth {
my $self = shift;
$cache = OpenSRF::Utils::Cache->new('global') unless $cache;
@@ -139,6 +140,7 @@ sub checkauth {
$self->event(OpenILS::Event->new('NO_SESSION'));
return undef;
}
+
=cut
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/ModsParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/ModsParser.pm
index 287890c..1ab2c86 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/ModsParser.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/ModsParser.pm
@@ -162,7 +162,8 @@ sub get_field_value {
return @string;
}
-=head
+=head1 old implementation
+
sub _modsdoc_to_values {
my( $self, $mods ) = @_;
my $data = {};
@@ -179,6 +180,7 @@ sub _modsdoc_to_values {
}
return $data;
}
+
=cut
sub modsdoc_to_values {
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/Redirect.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/Redirect.pm
index 99667d0..560ccc6 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/Redirect.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/Redirect.pm
@@ -100,7 +100,8 @@ sub handler {
$url .= "/eg/opac/home";
$url .= "?orig_loc=$orig_loc" if $orig_loc;
-=head potential locale/skin implementation
+=head1 potential locale/skin implementation
+
if($locale ne 'en-US') {
$apache->headers_out->add(
"Set-Cookie" => $cgi->cookie(
diff --git a/Open-ILS/src/perlmods/xt/author/pod.t b/Open-ILS/src/perlmods/xt/author/pod.t
new file mode 100644
index 0000000..da5da6f
--- /dev/null
+++ b/Open-ILS/src/perlmods/xt/author/pod.t
@@ -0,0 +1,10 @@
+#!/usr/bin/perl
+
+use strict;
+use warnings;
+
+use Test::More;
+eval "use Test::Pod 1.00";
+plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
+
+all_pod_files_ok();
-----------------------------------------------------------------------
Summary of changes:
.../lib/OpenILS/Application/Acq/Picklist.pm | 4 +++-
.../lib/OpenILS/Application/Storage/Publisher.pm | 4 ++--
.../Application/Storage/Publisher/biblio.pm | 2 +-
.../src/perlmods/lib/OpenILS/Utils/CStoreEditor.pm | 4 +++-
.../src/perlmods/lib/OpenILS/Utils/ModsParser.pm | 4 +++-
Open-ILS/src/perlmods/lib/OpenILS/WWW/Redirect.pm | 3 ++-
Open-ILS/src/perlmods/xt/author/pod.t | 10 ++++++++++
.../edi_scratch/baker_taylor.ordrsp.jedi.pl | 2 +-
8 files changed, 25 insertions(+), 8 deletions(-)
create mode 100644 Open-ILS/src/perlmods/xt/author/pod.t
hooks/post-receive
--
Evergreen ILS
More information about the open-ils-commits
mailing list