[open-ils-commits] [GIT] Evergreen ILS branch master updated. 4d0676d86ab0c8c85416666d6fcb73c64457647c

Wed Sep 28 15:47:12 EDT 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  4d0676d86ab0c8c85416666d6fcb73c64457647c (commit)
      from  6970e27424e43fa35c2e876025bfe89091b553f2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4d0676d86ab0c8c85416666d6fcb73c64457647c
Author: Dan Scott <dscott at laurentian.ca>
Date:   Thu Sep 22 12:51:22 2011 -0400

    LP856567: Mark HTML report output as Unicode-encoded
    
    Non-ASCII characters in report ouput that has been generated in HTML
    format appears to be corrupted when viewed in a browser. This can be
    manually corrected by switching the "Encoding" browser option, but it
    would be better to include <meta charset='utf-8'> in the output HTML to
    tell the browser directly.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/reporter/clark-kent.pl b/Open-ILS/src/reporter/clark-kent.pl
index d618782..e8cf88d 100755
--- a/Open-ILS/src/reporter/clark-kent.pl
+++ b/Open-ILS/src/reporter/clark-kent.pl
@@ -443,6 +443,7 @@ sub build_html {
 	print $index <<"	HEADER";
 <html>
 	<head>
+		<meta charset='utf-8'>
 		<title>$$r{report}{name}</title>
 		<style>
 			table { border-collapse: collapse; }
@@ -474,7 +475,7 @@ sub build_html {
 	push @links, "<a class='dim' href='report-data.html.debug.html'>Debugging Info</a>";
 
 	my $debug = new FileHandle (">$file.debug.html") or die "Cannot write to '$file.debug.html'";
-	print $debug "<html><head><title>DEBUG: $$r{report}{name}</title></head><body>";
+	print $debug "<html><head><meta charset='utf-8'><title>DEBUG: $$r{report}{name}</title></head><body>";
 
 	{	no warnings;
 		print $debug '<h1>Generated SQL</h1><pre>' . $r->{resultset}->toSQL() . "</pre><a href='$file'>Back to output index</a><hr/>";
@@ -496,7 +497,7 @@ sub build_html {
 	if ($r->{html_format}) {
 		# create the raw output html file
 		my $raw = new FileHandle (">$file.raw.html") or die "Cannot write to '$file.raw.html'";
-		print $raw "<html><head><title>$$r{report}{name}</title>";
+		print $raw "<html><head><meta charset='utf-8'><title>$$r{report}{name}</title>";
 
 		print $raw <<'		CSS';
 			<style>

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/reporter/clark-kent.pl |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS
