[open-ils-commits] [GIT] Evergreen ILS branch master updated. 5134977a87331b39dd4db0c1dae4386bdbfc9664

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  5134977a87331b39dd4db0c1dae4386bdbfc9664 (commit)
       via  cb24cc8dcf50ad027f161d9f8507ef4ebe59f22b (commit)
      from  84d91473fd54686f472205c5d5826d20f0849c7f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5134977a87331b39dd4db0c1dae4386bdbfc9664
Author: Ben Shum <bshum at biblio.org>
Date:   Tue Dec 18 00:12:38 2012 -0500

    Stamping upgrade script for hold request email notify default false
    
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/sql/Pg/002.schema.config.sql b/Open-ILS/src/sql/Pg/002.schema.config.sql
index 0886d9e..d069cc0 100644
--- a/Open-ILS/src/sql/Pg/002.schema.config.sql
+++ b/Open-ILS/src/sql/Pg/002.schema.config.sql
@@ -87,7 +87,7 @@ CREATE TRIGGER no_overlapping_deps
     BEFORE INSERT OR UPDATE ON config.db_patch_dependencies
     FOR EACH ROW EXECUTE PROCEDURE evergreen.array_overlap_check ('deprecates');
 
-INSERT INTO config.upgrade_log (version, applied_to) VALUES ('0745', :eg_version); -- mrpeters-isl/bshum/dbs
+INSERT INTO config.upgrade_log (version, applied_to) VALUES ('0746', :eg_version); -- mrpeters-isl/bshum
 
 CREATE TABLE config.bib_source (
 	id		SERIAL	PRIMARY KEY,
diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.action.hold_request.email_notify_default_false.sql b/Open-ILS/src/sql/Pg/upgrade/0746.action.hold_request.email_notify_default_false.sql
similarity index 60%
rename from Open-ILS/src/sql/Pg/upgrade/XXXX.action.hold_request.email_notify_default_false.sql
rename to Open-ILS/src/sql/Pg/upgrade/0746.action.hold_request.email_notify_default_false.sql
index f899cec..166f24f 100644
--- a/Open-ILS/src/sql/Pg/upgrade/XXXX.action.hold_request.email_notify_default_false.sql
+++ b/Open-ILS/src/sql/Pg/upgrade/0746.action.hold_request.email_notify_default_false.sql
@@ -1,6 +1,6 @@
 BEGIN;
 
-SELECT evergreen.upgrade_deps_block_check('XXXX', :eg_version);
+SELECT evergreen.upgrade_deps_block_check('0746', :eg_version);
 
 ALTER TABLE action.hold_request ALTER COLUMN email_notify SET DEFAULT 'false';
 

commit cb24cc8dcf50ad027f161d9f8507ef4ebe59f22b
Author: Michael Peters <mrpeters at library.in.gov>
Date:   Thu Sep 13 16:28:04 2012 -0400

    LP#1047475 Set action.hold_request.email_notify to default to false
    
    LP#1047475 points out that email notify prefs are ignored in TPAC.
    Even if a patron deselects email notify during hold request time, it
    will always be set to true due to the column default.
    
    This change defaults the column in the database to false (like most
    other similar columns are) and resolves the bug.
    
    Credit to Steve Callender for the idea.
    
    Signed-off-by: Michael Peters <mrpeters at library.in.gov>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/sql/Pg/090.schema.action.sql b/Open-ILS/src/sql/Pg/090.schema.action.sql
index 1af6e89..833d7bc 100644
--- a/Open-ILS/src/sql/Pg/090.schema.action.sql
+++ b/Open-ILS/src/sql/Pg/090.schema.action.sql
@@ -393,7 +393,7 @@ CREATE TABLE action.hold_request (
 	hold_type		TEXT				NOT NULL, -- CHECK (hold_type IN ('M','T','V','C')),  -- XXX constraint too constraining...
 	holdable_formats	TEXT,
 	phone_notify		TEXT,
-	email_notify		BOOL				NOT NULL DEFAULT TRUE,
+	email_notify		BOOL				NOT NULL DEFAULT FALSE,
 	sms_notify		TEXT,
 	sms_carrier		INT REFERENCES config.sms_carrier (id),
 	frozen			BOOL				NOT NULL DEFAULT FALSE,
diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.action.hold_request.email_notify_default_false.sql b/Open-ILS/src/sql/Pg/upgrade/XXXX.action.hold_request.email_notify_default_false.sql
new file mode 100644
index 0000000..f899cec
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/upgrade/XXXX.action.hold_request.email_notify_default_false.sql
@@ -0,0 +1,7 @@
+BEGIN;
+
+SELECT evergreen.upgrade_deps_block_check('XXXX', :eg_version);
+
+ALTER TABLE action.hold_request ALTER COLUMN email_notify SET DEFAULT 'false';
+
+COMMIT;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/sql/Pg/002.schema.config.sql          |    2 +-
 Open-ILS/src/sql/Pg/090.schema.action.sql          |    2 +-
 ...ion.hold_request.email_notify_default_false.sql |    7 +++++++
 3 files changed, 9 insertions(+), 2 deletions(-)
 create mode 100644 Open-ILS/src/sql/Pg/upgrade/0746.action.hold_request.email_notify_default_false.sql


hooks/post-receive
-- 
Evergreen ILS