[open-ils-commits] [GIT] Evergreen ILS branch master updated. b389c8c8593230d3ad58a1184a33509685daa7aa

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  b389c8c8593230d3ad58a1184a33509685daa7aa (commit)
      from  c3125b355fc442689dc2f203bc535bf068d63283 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b389c8c8593230d3ad58a1184a33509685daa7aa
Author: Dan Scott <dscott at laurentian.ca>
Date:   Fri Dec 21 21:15:49 2012 -0500

    Facets should not be sticky when users click "Search"
    
    We were using a hidden form variable to track which facets were in use,
    at the same time as relying on the GET params to actually display the
    facets, and munging the links on the remaining facets to properly
    add/subtract facets.
    
    The result of the hidden form variable was that:
    
    1) clicking the Search button would unexpectedly result in the facet
    applying to the new search (wat)
    
    2) applying two facets at once and then searching again would result
    in the facet vars being treated as a raw array.
    
    Thanks to Dan Pearl for inspiring this patch with his fix for the latter
    problem, and Kathy Lussier's recognition of the basic problem.
    
    Closes LP# 1092946 and 1091659.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/templates/opac/results.tt2 b/Open-ILS/src/templates/opac/results.tt2
index e5612cc..7b2917e 100644
--- a/Open-ILS/src/templates/opac/results.tt2
+++ b/Open-ILS/src/templates/opac/results.tt2
@@ -18,9 +18,6 @@
     PROCESS get_library;
 %]
     <form action="[% ctx.opac_root %]/results" method="GET">
-    [% IF CGI.param('facet') %]
-    <input type="hidden" name="facet" value="[% CGI.param('facet') %]" />
-    [% END %]
     <div id="search-wrapper">
         [% INCLUDE "opac/parts/searchbar.tt2" took_care_of_form=1 %]
     </div>

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/opac/results.tt2 |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Evergreen ILS