[open-ils-commits] [GIT] Evergreen ILS branch master updated. adc1e00adad32f1c3f9049b9417584b14aba3576

Evergreen Git git at git.evergreen-ils.org
Sun Dec 23 15:49:40 EST 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  adc1e00adad32f1c3f9049b9417584b14aba3576 (commit)
      from  d5cfac2363f95ea9da5b1f6ad8fa4cad1c53778d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit adc1e00adad32f1c3f9049b9417584b14aba3576
Author: Thomas Berezansky <tsbere at mvlc.org>
Date:   Tue Oct 2 13:31:13 2012 -0400

    TPAC - SMS Number Munging
    
    Addresses LP bug 1016654 - Despite the hint telling users not to use
    hyphens when entering a text notification number, we have patrons who
    are entering the hyphens causing the text notification to fail.
    
    Munge "pretty printed" numbers into raw sets of digits in the A/T helper.
    
    This allows aliases to still work for services that support them.
    
    Signed-off-by: Thomas Berezansky <tsbere at mvlc.org>
    Signed-off-by: Michael Peters <mrpeters at library.in.gov>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm
index f6702ce..62ca21b 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor.pm
@@ -338,6 +338,12 @@ $_TT_helpers = {
         };
         my $carriers = new_editor()->json_query($query);
 
+        # If this looks like a pretty-formatted number drop the pretty-formatting
+        # Otherwise assume it may be a literal alias instead of a real number
+        if ($sms_notify =~ m/^[- ()0-9]*$/) {
+            $sms_notify =~ s/[- ()]//g;
+        }
+
         my @addresses = ();
         foreach my $carrier ( @{ $carriers } ) {
             my $address = $carrier->{email_gateway};

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Trigger/Reactor.pm     |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list