[open-ils-commits] [GIT] Evergreen ILS branch rel_2_1 updated. cca9eb12e0173214a1521b45cc16a79e348421b3

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_1 has been updated
       via  cca9eb12e0173214a1521b45cc16a79e348421b3 (commit)
      from  1fc6e778db6ba859c63c20a799e7c4b2cb331837 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cca9eb12e0173214a1521b45cc16a79e348421b3
Author: James Fournie <jfournie at sitka.bclibraries.ca>
Date:   Tue Nov 15 16:56:16 2011 -0800

    Making the user profile selector disabled rather than readonly
    in the case of a user editing their own account.  This prevents
    a nasty bug whereby Dojo widgets with the readOnly flag set
    become labels and therefore do not correctly hold a 'value'
    like a normal form widget.  See LP#806625 for details.
    
    Signed-off-by: James Fournie <jfournie at sitka.bclibraries.ca>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/web/js/ui/default/actor/user/register.js b/Open-ILS/web/js/ui/default/actor/user/register.js
index f74b110..e007755 100644
--- a/Open-ILS/web/js/ui/default/actor/user/register.js
+++ b/Open-ILS/web/js/ui/default/actor/user/register.js
@@ -816,8 +816,6 @@ function fleshFMRow(row, fmcls, args) {
         // not overwritten when the profile groups arrive and update
         wargs.forceSync = true;
         wargs.disableQuery = {usergroup : 'f'};
-        if(!patron.isnew() && !checkGrpAppPerm(patron.profile()))
-            wargs.readOnly = true;
     } else {
         wargs.forceSync = false;
     }
@@ -830,7 +828,12 @@ function fleshFMRow(row, fmcls, args) {
     var widget = new openils.widget.AutoFieldWidget(wargs);
     widget.build(
         function(w, ww) {
-            if(fmfield == 'profile') { trimGrpTree(ww); }
+            if(fmfield == 'profile') {
+                trimGrpTree(ww);
+                if(!patron.isnew() && !checkGrpAppPerm(patron.profile())){
+                    w.attr('disabled', true);
+                }
+            }
         }
     );
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/actor/user/register.js |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Evergreen ILS