[open-ils-commits] [GIT] Evergreen ILS branch master updated. 05679cce8d1b4903f65262bebbdc384f88238b9d

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  05679cce8d1b4903f65262bebbdc384f88238b9d (commit)
      from  8e74348fac9c9dd9017d80ddd22e68a6683ee984 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 05679cce8d1b4903f65262bebbdc384f88238b9d
Author: Jason Etheridge <jason at esilibrary.com>
Date:   Tue Jan 3 15:46:25 2012 -0500

    More aggressive recalc of standing penalties
    
    In the staff client, the Refresh button in the patron display will explicitly
    ask the server to recalculate standing penalties for the patron. Other automatic
    refresh-like behavior meant to synchronize parts of the patron display will not
    do this.
    
    This change tweaks the logic to ask for a recalculation with all refresh-like
    behavior in the patron display, and will catch such things as staff changing the
    user's permisssion profile.
    
    An example of how you might test this:
    
    Admin -> Local Administration -> Group Penalty Thresholds
    
    New Penalty Threshold
    
    Group: Volunteers
    Org Unit: CONS
    Penalty: PATRON_EXCEEDS_FINES
    Threshold: 1
    
    Save
    
    Register user with Profile of Patrons
    
    Load patron, Bills, Bill Patron, Amount: 5, Submit this Bill
    
    Edit
    
    Main (Profile) Permission Group: Volunteers, Save
    
    The interface should refresh and show a Maximum Bills penalty in the patron
    summary.
    
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    Signed-off-by: Bill Erickson <berick at esilibrary.com>

diff --git a/Open-ILS/xul/staff_client/server/patron/display.js b/Open-ILS/xul/staff_client/server/patron/display.js
index 3cf9f96..1eec41f 100644
--- a/Open-ILS/xul/staff_client/server/patron/display.js
+++ b/Open-ILS/xul/staff_client/server/patron/display.js
@@ -174,10 +174,6 @@ patron.display.prototype = {
                         ['command'],
                         function(ev) {
                             try { document.getElementById("PatronNavBarScrollbox").ensureElementIsVisible( document.getElementById("PatronNavBar_refresh" ) ); } catch(E) {};
-                            obj.network.simple_request(
-                                'RECALCULATE_STANDING_PENALTIES',
-                                [ ses(), obj.patron.id() ]
-                            );
                             obj.refresh_all();
                         }
                     ],
@@ -805,6 +801,10 @@ patron.display.prototype = {
         var obj = this;
         obj.controller.view.patron_name.setAttribute('value', $("patronStrings").getString('staff.patron.display.init.retrieving'));
         document.documentElement.setAttribute('class','');
+        obj.network.simple_request(
+            'RECALCULATE_STANDING_PENALTIES',
+            [ ses(), obj.patron.id() ]
+        );
         try { obj.summary_window.refresh(); } catch(E) { obj.error.sdump('D_ERROR', E + '\n'); }
         try { obj.refresh_deck(); } catch(E) { obj.error.sdump('D_ERROR', E + '\n'); }
     },

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/xul/staff_client/server/patron/display.js |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS