[open-ils-commits] [GIT] Evergreen ILS branch rel_2_1 updated. 728a4156b15b0934b78d9bdc835cb50b97e816e6

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_1 has been updated
       via  728a4156b15b0934b78d9bdc835cb50b97e816e6 (commit)
      from  7a238e086a1a074914dcd8f53a663b109f106685 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 728a4156b15b0934b78d9bdc835cb50b97e816e6
Author: Jason Etheridge <jason at esilibrary.com>
Date:   Fri Jan 6 18:02:06 2012 -0800

    Fix shelf_expire_time closed date overlap test
    
    One-liner courtesy of berick.
    
    * Steps to test
    
    This is time and timezone sensitive, so on the server:
    
    Change your timezone to America/Los Angeles: sudo dpkg-reconfigure tzdata
    Stop your NTP server: sudo /etc/init.d/ntp stop
    Set the time to 5pm: sudo date --set 17:00:00
    
    Stop Evergreen, Restart Postgres, Start Evergreen
    
    On the client:
    
    Make sure the timezone is set to Pacific time.
    
    1) Change the Library Setting "Default hold shelf expire interval" in the Holds group to have a value of "7 days" (without the quotes) for org BR1 (or if there is an existing value, you can keep it).
    
    2) Create a bib with one item: htest1  (Status of Available)
    
    3) Place a title level hold on the bib
    
    4) Check in htest1 (it should get captured for the hold)
    
    5) Browse the Hold Shelf and note the Shelf Expire Time for the hold that captured htest1 (it should be a week from now, unless you already have a conflicting closed date configured)
    
    6) Cancel the hold and re-check-in htest1 (to remove the Hold Shelf status)
    
    7) In the Closed Dates Editor, Add Single Day Closing for the date noticed previously in the Shelf Expire Time for BR1.
    
    8) Place a title level hold on the bib
    
    9) Check in htest1 (it should get captured for the hold)
    
    10) Browse the Hold Shelf and note the Shelf Expire Time for the hold that captured htest1 (now the bug is illustrated if you get the same date for Shelf Expire Time as you did before, since that day is now a Closed Date and should be skipped over.  The patch should fix this.)
    
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 797c094..405583c 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -2928,7 +2928,7 @@ sub put_hold_on_shelf {
     # closed date, push it out to the first open date
     my $dateinfo = $U->storagereq(
         'open-ils.storage.actor.org_unit.closed_date.overlap', 
-        $hold->pickup_lib, $expire_time);
+        $hold->pickup_lib, $expire_time->strftime('%FT%T%z'));
 
     if($dateinfo) {
         my $dt_parser = DateTime::Format::ISO8601->new;

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Circ/Circulate.pm      |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS