[open-ils-commits] [GIT] Evergreen ILS branch master updated. cde5d7218d4b6cfa782257cf488a1a317542fa13

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  cde5d7218d4b6cfa782257cf488a1a317542fa13 (commit)
      from  4b2edba197b25dc86001d1de35aca64d7f3aa266 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cde5d7218d4b6cfa782257cf488a1a317542fa13
Author: Bill Erickson <berick at esilibrary.com>
Date:   Mon Jul 16 16:56:10 2012 -0400

    Squelch uninitialized var warning from hold_copy_targeter
    
    open-ils.storage_stderr.log was getting filled with entries like:
    
    "Use of uninitialized value in concatenation (.) or string at
    /usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm"
    
    ... consuming disk space endlessly. Stop that!
    
    (Stealing Lebbeous' footwork and providing a slightly different solution.)
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>
    Signed-off-by: Dan Scott <dscott at laurentian.ca>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 7c07e6f..ada8dc4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -1285,7 +1285,7 @@ sub new_hold_copy_targeter {
 			my @good_copies;
 			for my $c (@$all_copies) {
 				# current target
-				next if ($c->id eq $hold->current_copy);
+				next if ($hold->current_copy and $c->id eq $hold->current_copy);
 
 				# skip on circ lib is closed IFF we care
 				my $ignore_closing;

-----------------------------------------------------------------------

Summary of changes:
 .../Application/Storage/Publisher/action.pm        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS