[open-ils-commits] [GIT] Evergreen ILS branch rel_2_1 updated. c243355bec838c7914129ed12ebea3b6dac80371

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_1 has been updated
       via  c243355bec838c7914129ed12ebea3b6dac80371 (commit)
      from  3957f63b56713f6f0f3273813cb07269621d842b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c243355bec838c7914129ed12ebea3b6dac80371
Author: Bill Erickson <berick at esilibrary.com>
Date:   Mon Jul 16 16:56:10 2012 -0400

    Squelch uninitialized var warning from hold_copy_targeter
    
    open-ils.storage_stderr.log was getting filled with entries like:
    
    "Use of uninitialized value in concatenation (.) or string at
    /usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm"
    
    ... consuming disk space endlessly. Stop that!
    
    (Stealing Lebbeous' footwork and providing a slightly different solution.)
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>
    Signed-off-by: Dan Scott <dscott at laurentian.ca>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index e4d7354..ddca93e 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -1276,7 +1276,7 @@ sub new_hold_copy_targeter {
 			my @good_copies;
 			for my $c (@$all_copies) {
 				# current target
-				next if ($c->id eq $hold->current_copy);
+				next if ($hold->current_copy and $c->id eq $hold->current_copy);
 
 				# circ lib is closed
 				next if ( grep { ''.$_->org_unit eq ''.$c->circ_lib } @closed );

-----------------------------------------------------------------------

Summary of changes:
 .../Application/Storage/Publisher/action.pm        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS